Skip to content

feat(xml): namespace-correct FromXml core + winrm migration #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
irvingouj@Devolutions (irvingoujAtDevolution) merged 3 commits into from
Jun 25, 2026
Merged

feat(xml): namespace-correct FromXml core + winrm migration #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c87e7e
feat(xml): namespace-correct FromXml derive (kills the deserialize vi…
irvingoujAtDevolution Jun 23, 2026
543de7d
refactor(winrm): replace the XML visitor framework with direct FromXml
irvingoujAtDevolution Jun 23, 2026
b2320d1
style(xml): fmt + clippy clean for the FromXml migration
irvingoujAtDevolution Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/ironposh-client-core/src/runspace_pool/expect_shell_connected.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use base64::Engine;
use ironposh_psrp::{MessageType, PsrpMessage, fragmentation};
use ironposh_winrm::soap::SoapEnvelope;
use ironposh_xml::parser::XmlDeserialize;
use ironposh_xml::mapping::FromXml;
use tracing::{debug, info, trace, warn};

use super::enums::RunspacePoolState;
Expand All @@ -23,7 +23,7 @@ impl ExpectShellConnected {

let parsed = ironposh_xml::parser::parse(response)?;

let soap_response = SoapEnvelope::from_node(parsed.root_element())
let soap_response = SoapEnvelope::from_xml(parsed.root_element())
.map_err(crate::PwshCoreError::XmlParsingError)?;

RunspacePool::fault_to_error(&soap_response)?;
Expand Down
4 changes: 2 additions & 2 deletions crates/ironposh-client-core/src/runspace_pool/expect_shell_created.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use ironposh_winrm::soap::SoapEnvelope;
use ironposh_xml::parser::XmlDeserialize;
use ironposh_xml::mapping::FromXml;

use super::pool::RunspacePool;

Expand All @@ -14,7 +14,7 @@ impl ExpectShellCreated {

let parsed = ironposh_xml::parser::parse(response)?;

let soap_response = SoapEnvelope::from_node(parsed.root_element())
let soap_response = SoapEnvelope::from_xml(parsed.root_element())
.map_err(crate::PwshCoreError::XmlParsingError)?;

runspace_pool.shell.accept_create_response(&soap_response)?;
Expand Down
8 changes: 4 additions & 4 deletions crates/ironposh-client-core/src/runspace_pool/incoming.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ use ironposh_psrp::{
SessionCapability, fragmentation,
};
use ironposh_winrm::{soap::SoapEnvelope, ws_management::WsAction};
use ironposh_xml::parser::XmlDeserialize;
use ironposh_xml::mapping::FromXml;
use rsa::pkcs1v15::Pkcs1v15Encrypt;
use tracing::{debug, error, info, instrument, trace, warn};
use uuid::Uuid;
Expand Down Expand Up @@ -46,7 +46,7 @@ impl RunspacePool {
}

let parsed = ironposh_xml::parser::parse(soap_envelope)?;
let soap_envelope = SoapEnvelope::from_node(parsed.root_element())
let soap_envelope = SoapEnvelope::from_xml(parsed.root_element())
.map_err(crate::PwshCoreError::XmlParsingError)?;

Self::fault_to_error(&soap_envelope)?;
Expand Down Expand Up @@ -82,7 +82,7 @@ impl RunspacePool {
}

let parsed = ironposh_xml::parser::parse(soap_envelope)?;
let soap_envelope = SoapEnvelope::from_node(parsed.root_element())
let soap_envelope = SoapEnvelope::from_xml(parsed.root_element())
.map_err(crate::PwshCoreError::XmlParsingError)?;

Self::fault_to_error(&soap_envelope)?;
Expand Down Expand Up @@ -147,7 +147,7 @@ impl RunspacePool {
e
})?;

let soap_envelope = SoapEnvelope::from_node(parsed.root_element()).map_err(|e| {
let soap_envelope = SoapEnvelope::from_xml(parsed.root_element()).map_err(|e| {
error!(target: "soap", error = %e, "failed to parse SOAP envelope");
crate::PwshCoreError::XmlParsingError(e)
})?;
Expand Down
Loading