refactor (pool 3/N): extract host-call construction/classification into host_call.rs#27
Merged
irvingouj@Devolutions (irvingoujAtDevolution) merged 3 commits intoJun 23, 2026
Conversation
Pure, behavior-preserving move of the SecureString in-place encryption walk, the AES-256-CBC helper, and KeyExchangeState out of the ~1900-line pool.rs into a dedicated runspace_pool/crypto.rs module (private, items pub(super)). First step of decomposing the RunspacePool god-object; no logic or wire-format change.
Make the `state` field private and route all transitions through `set_state()` / reads through `state()` / terminal checks through `is_terminal()`, instead of the RunspacePool poking the field directly. Behavior-preserving; no wire/logic change.
…n into host_call.rs Move the pure PipelineHostCall parsing and the needs-session-key classification out of pool.rs into a new private runspace_pool::host_call module (named to avoid collision with crate::host). Fragmentation-coupled send + the pending_host_calls queue stay in the pool. Behavior-preserving.
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
stack/08-pool-extract-host
branch
from
344aa97 to
ad6494d
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
stack/07-pipeline-owns-state
branch
from
c6453e5 to
25ea785
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
changed the base branch from
stack/07-pipeline-owns-state
to
master
irvingouj@Devolutions (irvingoujAtDevolution)
deleted the
stack/08-pool-extract-host
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #26. Third step of decomposing the
RunspacePoolgod-object.Extracts the pure host-call logic out of
pool.rsinto a new privaterunspace_pool::host_callmodule (named to avoid collision withcrate::host):pipeline_host_call_from(..)— thePipelineHostCall→HostCallparsing.needs_session_key(&HostCall)— the secure-string classification (incl. thePromptspecial case).send_pipeline_host_responseand thepending_host_callsqueue stay in the pool (pool state-machine concern) — partial, deliberate.Reviewed: Benoit-style pass (fixed: module name
host→host_callto avoid colliding withcrate::host) + Codex pass (NO_ISSUES_FOUND).