refactor (pool 1/N): extract PSRP session crypto into crypto.rs#25
Closed
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 1 commit into
Closed
Conversation
This was referenced Jun 23, 2026
Pure, behavior-preserving move of the SecureString in-place encryption walk, the AES-256-CBC helper, and KeyExchangeState out of the ~1900-line pool.rs into a dedicated runspace_pool/crypto.rs module (private, items pub(super)). First step of decomposing the RunspacePool god-object; no logic or wire-format change.
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
stack/06-pool-extract-crypto
branch
from
2fe1309 to
ce54a1f
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
changed the base branch from
master
to
style/rustfmt
irvingouj@Devolutions (irvingoujAtDevolution)
deleted the
stack/06-pool-extract-crypto
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of decomposing the ~1900-line
RunspacePoolgod-object (now that #20–#24 are merged, this stacks onmaster).Pure, behavior-preserving extraction of the SecureString / PSRP key-exchange crypto into
runspace_pool/crypto.rs:KeyExchangeState+ the SecureString in-place encryption walk + the AES-256-CBC helper move out ofpool.rs; module is private, itemspub(super).cargo clippyclean,ironposh-client-coretests green.Reviewed: Benoit-style pass + Codex pass (nits fixed: added
//!module doc; narrowedmodvisibility).