feat(dgw): mDNS network scan support#693
Conversation
irvingouj@Devolutions (irvingoujAtDevolution)
requested review from
Benoît Cortier (CBenoit) and
Paul Dumais (pauldumais)
Paul Dumais (pauldumais)
left a comment
Paul Dumais (pauldumais)
left a comment
There was a problem hiding this comment.
Wow this is awesome, LGTM
| "polling 2.8.0", | ||
| "socket2 0.4.10", |
There was a problem hiding this comment.
issue (non-blocking): This crate is using outdated dependencies, and this causes dependency duplication. Do you think you could send a PR for updating them soonish? It’s okay to wait until you are done with implementing the feature first. If you don’t do it now, can you create a Jira ticket to not forget? Thank you.
There was a problem hiding this comment.
There was a problem hiding this comment.
created PR to mdsn-sd
| pub ping_interval: u64, // in milliseconds | ||
| pub ping_timeout: u64, // in milliseconds | ||
| pub broadcast_timeout: u64, // in milliseconds | ||
| pub port_scan_timeout: u64, // in milliseconds | ||
| pub netbios_timeout: u64, // in milliseconds | ||
| pub netbios_interval: u64, // in milliseconds | ||
| pub max_wait_time: u64, // max_wait for entire scan duration in milliseconds, suggested! | ||
| pub ping_interval: u64, // in milliseconds | ||
| pub ping_timeout: u64, // in milliseconds | ||
| pub broadcast_timeout: u64, // in milliseconds | ||
| pub port_scan_timeout: u64, // in milliseconds | ||
| pub netbios_timeout: u64, // in milliseconds | ||
| pub netbios_interval: u64, // in milliseconds | ||
| pub mdns_meta_query_timeout: u64, // in milliseconds | ||
| pub mdns_single_query_timeout: u64, // in milliseconds | ||
| pub max_wait_time: u64, // max_wait for entire scan duration in milliseconds, suggested! |
There was a problem hiding this comment.
thought: We should probably use the Duration type instead. Should be addressed separately.
Converted to draft to make it obvious. |
Benoît Cortier (CBenoit)
changed the title
irvingouj@Devolutions (irvingoujAtDevolution)
requested a review
from Benoît Cortier (CBenoit)
Co-authored-by: Benoît Cortier <bcortier@proton.me>
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
Network-Scan-Zero-Conf
branch
from
3682b54 to
027b9ab
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
marked this pull request as ready for review
Benoît Cortier (CBenoit)
left a comment
Benoît Cortier (CBenoit)
left a comment
There was a problem hiding this comment.
Thank you! Looks mostly good. I spotted two other issues which should be fixed, and then we can merge.
| .nest("/jet/config", config::make_router(state.clone())) | ||
| .nest("/jet/session", session::make_router(state.clone())) | ||
| .nest("/jet/sessions", sessions::make_router(state.clone())) | ||
| .nest("/jet/sessions", session::make_router(state.clone())) |
There was a problem hiding this comment.
issue: Any reason for this? This looks very problematic (creating the wrong router).
There was a problem hiding this comment.
this is a mistake, thank you for point it out!
There was a problem hiding this comment.
updated
irvingouj@Devolutions (irvingoujAtDevolution)
requested a review
from Benoît Cortier (CBenoit)
Co-authored-by: Benoît Cortier <bcortier@proton.me>
Merci! |
3 participants
Add mdns to network scan, added some extra helper method for better readbility and maintainbility.
Open for review but needs to wait for the #689 to be merged first