Refactor/migrate agp9#4
Merged
Merged
Conversation
DeveloprOfThings
commented
Jun 19, 2026
DeveloprOfThings
commented
Owner
- Migrated project to use AGP 9.0.
- Refactored iosMain/../Util.kt
….kespl.bluetooth`) and updated imports across the `iosMain` source-set to reflect this change. - Optimized `ByteArray.toNSData()` by using `usePinned` to access memory directly instead of allocating a new array in a `memScoped` block. - Added an empty check to `ByteArray.toNSData()` that returns an empty `NSData` instance if the array is empty. - Removed redundant internal imports in `IOSLeCharacteristicWrapper.kt` and `PlatformLeClient.ios.kt`. - Cleaned up `build.gradle.kts` by removing a trailing newline.
…ultiplatform library using the `com.android.kotlin.multiplatform.library` plugin.
- Included a new `:androidApp` module in `settings.gradle.kts`.
- Updated Gradle wrapper to version `9.1.0`.
- Bumped several library and plugin versions in `libs.versions.toml`, including:
- Kotlin to `2.3.21`
- Android Gradle Plugin to `9.0.1`
- Compose Multiplatform to `1.11.0`
- Koin to `4.2.1`
- Coroutines to `1.11.0`
- Removed `iosX64` target support across all modules.
- Migrated `@Preview` imports from `org.jetbrains.compose.ui.tooling.preview` to `androidx.compose.ui.tooling.preview`.
- Removed Android application components from `composeApp`, including `MainActivity`, `MainApplication`, launcher icons, and application-level resources.
- Updated `build.gradle.kts` files to use the modern `android` target configuration block instead of `androidLibrary`.
- Cleaned up `AndroidManifest.xml` in `composeApp` to reflect its transition to a library module.
- Added the `androidApp` module with initial configuration for Compose and Koin. - Implemented `MainActivity` with `installSplashScreen` and `enableEdgeToEdge` support. - Configured `MainApplication` to initialize Koin with `ESPContext`. - Added Bluetooth (scan and connect) and location permissions to `AndroidManifest.xml`. - Added standard application resources including themes, colors, strings, and adaptive launcher icons. - Defined backup and data extraction rules in `res/xml`.
This comment was marked as low quality.
This comment was marked as low quality.
…m prompt to improve AI code review quality for KMP and CMP projects, focusing on platform boundaries, `expect`/`actual` patterns, and state management. - Removed unused `kotlin.cinterop` imports in `iosMain/Util.kt`.
Code Review by GeminiHere is a quick review of the changes: 1. Typo in Android Manifest NamespaceIn +<manifest xmlns:android="http://schemas.github.com/apk/res/android" />
2. Dropped Intel iOS Simulator Support (
|
Code Review by GeminiHere is a quick review of the changes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.