Fix INITIAL_MARK_STACK_SIZE override in boehm-gc#531
Merged
Conversation
Nixpkgs now uses structured attrs (i.e. env.<VAR>), so this override wasn't working anymore. It makes a huge performance impact once GC kicks in (e.g. it speeds up a 12-core `nix search nixpkgs` from 10.5 to 6.5 seconds). Assisted-by: Claude Fable 5 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe boehmgc package override in packaging/dependencies.nix is modified so NIX_CFLAGS_COMPILE is set through a merged Changesboehmgc override update
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
cole-h
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Nixpkgs now uses structured attrs (i.e.
env.<VAR>), so this override wasn't working anymore. It makes a huge performance impact once GC kicks in (e.g. it speeds up a 12-corenix search nixpkgsfrom 10.5 to 6.5 seconds).Context
Summary by CodeRabbit