refactor: Rework Trainer generation#1394
Draft
innerthunder wants to merge 46 commits into
Draft
Conversation
DayKev
reviewed
Dec 5, 2025
10 tasks
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
innerthunder
force-pushed
the
refactor/trainer-generation
branch
from
December 9, 2025 22:04
c4583cf to
4e75c3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
TBD
Why am I making these changes?
The current Trainer generation system has several glaring issues that limit its usefulness:
TrainerConfigdata structure and the API for constructing it.TrainerConfigis built around the assumption that Trainers can only be either male or female.Trainerclass has too many responsibilities. As a Phaser sprite subclass, it should at most include methods for the trainer's visual effects, not the ~800 loc dedicated to config access, Party Pokemon generation, and other miscellaneous things.What are the changes from a developer perspective?
WIP
Screenshots/Videos
How to test the changes?
WIP
Checklist
main(such as a hotfix), has the game version been updated (pnpm update-version:patch/pnpm update-version:minor?betaas my base branchpnpm test:silent)pnpm test:create) or updated existing tests related to the PR's changes?Are there any localization additions or changes? If so:
Localizationtag to this PR?If there are no locale changes: