[Chore] (SC-206603) Update app branding#82
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the application’s branding by replacing the old Trello logo in the TrelloLink component with a new square SVG logo and refreshing standalone SVG assets (icon.svg and readme.svg) to align with the updated brand design. Class diagram for updated TrelloLogo componentclassDiagram
class TrelloLogo {
+render(): SVGElement
// Updated SVG markup for new branding
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Add an aria-label or <title> to the for accessibility so screen readers can identify the logo.
- Consider accepting props (e.g., className or size) in TrelloLogo to let consumers customize styling instead of hard-coded width/height.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Add an aria-label or <title> to the <svg> for accessibility so screen readers can identify the logo.
- Consider accepting props (e.g., className or size) in TrelloLogo to let consumers customize styling instead of hard-coded width/height.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Build for commit ea07b9c deployed to: https://trello-pr-82.ci.next.deskprodemo.com URLs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidence
Summary by Sourcery
Update app branding by replacing the TrelloLink TrelloLogo component with the new square SVG icon and refreshing the icon.svg and readme.svg assets.
Chores: