Skip to content

SC-197737 chore: arbitrary temporary file from tmp symbolic link dir parameter#89

Merged
tidbit1 merged 1 commit into
mainfrom
chore/SC-197737/arbitrary-temporary-file-tmp-symbolic-link-dir-parameter
Aug 12, 2025
Merged

SC-197737 chore: arbitrary temporary file from tmp symbolic link dir parameter#89
tidbit1 merged 1 commit into
mainfrom
chore/SC-197737/arbitrary-temporary-file-tmp-symbolic-link-dir-parameter

Conversation

@tidbit1

@tidbit1 tidbit1 commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Enforce tmp package upgrade by adding a pnpm override for ^0.2.4, bumping tmp to v0.2.5 in the lockfile, and removing os-tmpdir entries

Enhancements:

  • Upgrade tmp dependency from v0.0.33 to v0.2.5 in pnpm-lock.yaml and snapshots
  • Remove os-tmpdir references now that tmp v0.2.x handles temp directories

Build:

  • Add pnpm.overrides entry for tmp@^0.2.4 in package.json and reinforce it in pnpm-lock.yaml

@tidbit1
tidbit1 requested a review from Copilot August 12, 2025 09:09
@sourcery-ai

sourcery-ai Bot commented Aug 12, 2025

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR introduces a pnpm override to upgrade the tmp package to v0.2.x, updates the lockfile and associated snapshots to reflect the new version, and removes the now-unneeded os-tmpdir dependency entries.

File-Level Changes

Change Details Files
Added pnpm override for tmp
  • Inserted overrides.tmp entry in package.json
  • Added overrides.tmp under settings in pnpm-lock.yaml
package.json
pnpm-lock.yaml
Bumped tmp package version and updated metadata
  • Updated tmp resolution to v0.2.5 with new integrity hash
  • Raised engine requirement to node>=14.14
  • Cleaned up old tmp@0.0.33 snapshot entries
pnpm-lock.yaml
Removed os-tmpdir dependency entries
  • Deleted os-tmpdir@1.0.2 resolution section
  • Removed os-tmpdir references from snapshots
pnpm-lock.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a PNPM override to force the use of a specific version of the tmp package (^0.2.4) across the project, likely to address a security or compatibility issue with temporary file handling.

  • Adds PNPM package override configuration for the tmp dependency
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tidbit1 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions

Copy link
Copy Markdown

@tidbit1
tidbit1 merged commit 304a76f into main Aug 12, 2025
5 checks passed
@tidbit1
tidbit1 deleted the chore/SC-197737/arbitrary-temporary-file-tmp-symbolic-link-dir-parameter branch August 12, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants