[Bug] Fix App Requiring Users Re-Authenticate After Successful Login (SC-190943)#47
Merged
AFOJ merged 8 commits intoJun 12, 2025
Merged
Conversation
|
Build for commit d31dfda deployed to: https://quickbooks-pr-47.ci.next.deskprodemo.com URLs: |
HappyPaul55
previously approved these changes
Jun 11, 2025
AFOJ
changed the title
HappyPaul55
approved these changes
Jun 12, 2025
AFOJ
deleted the
bug/sc-190943/apps-quickbooks-app-login-does-not-persist
branch
June 12, 2025 15:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the following:
baseRequestfunction resulting in the initial request failing and always requiring a refresh to succeed.manifest.jsonLimitations
When installed with quick connect users will not be able to refresh their access tokens so they would be required to re-authenticate more frequently.
Evidence
When a user attempts logging in with a sandbox account but the app is setup with the sandbox flag is turned off.
When a user attempts logging in with a sandbox account but the app is setup with Quick Connect.
Logging in with a sandbox account.
QuickBooks.Demo.2025-06-11.Fix.Login.Not.Persisting.mp4
When a user installs the app with advanced connect but doesn't include a client id.