Upgrade Deps#72
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates application and tooling dependencies in package.json (and corresponding versions in pnpm-lock.yaml) to newer patch/minor releases to keep the runtime and build/test toolchain current. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Consider keeping
jest-environment-jsdomaligned with the major version ofjest(currently 29.7.0 vs 30.2.0) to avoid subtle test runner incompatibilities; upgradingjestas well or pinningjest-environment-jsdomto a 29.x version would make this more consistent.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider keeping `jest-environment-jsdom` aligned with the major version of `jest` (currently 29.7.0 vs 30.2.0) to avoid subtle test runner incompatibilities; upgrading `jest` as well or pinning `jest-environment-jsdom` to a 29.x version would make this more consistent.
## Individual Comments
### Comment 1
<location> `package.json:58` </location>
<code_context>
"eslint-plugin-react-hooks": "4.3.0",
"jest": "^29.7.0",
- "jest-environment-jsdom": "^30.0.5",
+ "jest-environment-jsdom": "^30.2.0",
"prettier": "^2.8.8",
"rollup-plugin-copy": "3.5.0",
</code_context>
<issue_to_address>
**issue (bug_risk):** Jest core and jest-environment-jsdom major versions are out of sync.
`jest` is still on 29.x (`"jest": "^29.7.0"`), but `jest-environment-jsdom` is now 30.x. Jest environments are expected to match Jest’s major version, and mixing 29/30 can cause subtle runtime issues. Please either keep `jest-environment-jsdom` on a 29.x-compatible version or upgrade `jest` to 30.x in the same change so they stay aligned.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| "eslint-plugin-react-hooks": "4.3.0", | ||
| "jest": "^29.7.0", | ||
| "jest-environment-jsdom": "^30.0.5", | ||
| "jest-environment-jsdom": "^30.2.0", |
There was a problem hiding this comment.
issue (bug_risk): Jest core and jest-environment-jsdom major versions are out of sync.
jest is still on 29.x ("jest": "^29.7.0"), but jest-environment-jsdom is now 30.x. Jest environments are expected to match Jest’s major version, and mixing 29/30 can cause subtle runtime issues. Please either keep jest-environment-jsdom on a 29.x-compatible version or upgrade jest to 30.x in the same change so they stay aligned.
There was a problem hiding this comment.
Pull request overview
This PR updates multiple dependencies and devDependencies to their latest patch or minor versions to improve stability, security, and access to bug fixes.
Key changes:
- Core dependencies upgraded including @deskpro/deskpro-ui (8.3.1→8.4.0), @sentry/react (9.38.0→9.47.1), and react-router-dom (7.6.3→7.11.0)
- Development tooling updated including typescript (5.8.3→5.9.3), vite (6.3.6→6.4.1), and various testing libraries
- Lock file updated with corresponding transitive dependency changes
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates 7 core dependencies and 9 devDependencies to newer minor/patch versions |
| pnpm-lock.yaml | Reflects package.json changes with updated dependency resolution tree and version pins |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Build for commit 2e67a7e deployed to: https://deskpro-news-pr-72.ci.next.deskprodemo.com URLs: |
This pull request updates several dependencies and devDependencies in the
package.jsonfile to their latest patch or minor versions. These upgrades help ensure compatibility, security, and access to the latest features and bug fixes.Dependency updates:
@deskpro/deskpro-ui,@sentry/react,@sentry/vite-plugin,@types/lodash,react-router-dom,semver, andsimplebarto newer versions for improved stability and features. [1] [2]DevDependency updates:
@babel/traverse,@testing-library/jest-dom,@types/react,@types/semver,jest-environment-jsdom,styled-components,ts-jest,typescript, andviteto keep the development environment current and reduce potential issues with outdated tooling. [1] [2]Summary by Sourcery
Update application and tooling dependencies to newer patch and minor versions to keep the project aligned with the current ecosystem.
Build: