SC-190481 bug: proxy-headers CORS pre-flight response#105
Closed
tidbit1 wants to merge 2 commits into
Closed
Conversation
Reviewer's GuideRefactors proxyFetch to introduce explicit method detection, separate header construction, and conditional inclusion of original request headers to prevent CORS pre-flight failures for OPTIONS requests. Flow diagram for conditional header logic in proxyFetchflowchart TD
A[Start proxyFetch] --> B{Is input a string?}
B -- Yes --> C[method = init?.method or 'GET']
B -- No --> D[method = input.method]
C --> E{Is method OPTIONS?}
D --> E
E -- Yes --> F[Do not set X-Proxy-Headers]
E -- No --> G[Set X-Proxy-Headers]
F --> H[Set other proxy headers]
G --> H
H --> I[Call fetch with POST and constructed headers]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
🚀 Storybook is ready! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Fix proxyFetch to omit custom headers for OPTIONS requests and refactor header assembly to handle all methods consistently
Bug Fixes:
Enhancements: