Skip to content

Use lower-case datadir#710

Open
jengelh wants to merge 1 commit into
DescentDevelopers:mainfrom
jengelh:datadir
Open

Use lower-case datadir#710
jengelh wants to merge 1 commit into
DescentDevelopers:mainfrom
jengelh:datadir

Conversation

@jengelh

@jengelh jengelh commented May 22, 2025

Copy link
Copy Markdown
Contributor

Pull Request Type

  • Runtime changes
    • Other changes

Description

Proposition:

  1. Use lower-case directory names for the standard filesystem (i.e. /usr/share/descent3 rather than /usr/share/Descent3)

  2. Reduce the path from $XDG_DATA_HOME/Outrage Entertainment/Descent 3 to just $XDG_DATA_HOME/descent3. This follows similar spirit to what e.g. Unreal Tournament did (going from ~/.loki/ut to just ~/.utpg once it was no longer maintained by Loki Software).

Related Issues

Changes behavior previously introduced by 8800f1b (real-1.5.0-574-g8800f1b4).
[openSUSE has had version git533.c99e57c and I had not updated in a while, so noticed 8800f1 only with delay.]

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Names with uppercase characters are outside the norm.
@winterheart

Copy link
Copy Markdown
Collaborator

Hi.

  1. Personally I don't see any benefits of this, but probably OK.
  2. We using this long path because of Linux Steam version already uses it. This allows to users smooth transition from Steam version. company / game is also recommended scheme from SDL and other frameworks (like Unity).

@jengelh

jengelh commented May 23, 2025

Copy link
Copy Markdown
Contributor Author

I figured Steam could be an issue. However, the D3 page says release date 2014-04-15 and there is nothing on the version update subpage, so it would seem they don't have the open-source engine and thus don't have commit 8800f1b yet.

Looking at my XDG dir, almost no one is using company labels.

Details
LibreCAD and QGIS do, but all the SDL programs don't, ironically.

./JOSM
./JOSM/autosave
./LibreCAD
./LibreCAD/LibreCAD
./Mousepad
./QGIS
./QGIS/QGIS3
./akonadi_migration_agent
./akonadi_migration_agent/gidmigratortext
./applications
./applications/wine
./apps
./apps/korganizer
./audacity
./audacity/Macros
./audacity/Plug-Ins
./chocolate-doom
./chocolate-doom/autoload
./chocolate-doom/music-packs
./chocolate-doom/savegames
./contacts
./cool-retro-term
./cool-retro-term/cool-retro-term
./crispy-doom
./crispy-doom/autoload
./crispy-doom/music-packs
./crispy-doom/savegames
./desktop-directories
./doom64ex-plus
./emailidentities
./emailidentities/2010548054
./emailidentities/780388899
./evolution
./evolution/addressbook
./evolution/calendar
./evolution/deviceidhashsalts
./evolution/mail
./evolution/memos
./evolution/storage
./evolution/tasks
./flatpak
./flatpak/db
./gedit
./geeqie
./geeqie/collections
./geeqie/metadata
./gegl-0.4
./gegl-0.4/plug-ins
./gnome-crosswords
./gnome-crosswords/downloads
./gnome-crosswords/saved-puzzles
./gravatar
./gvfs-metadata
./hugin
./ibus-table
./icons
./icons/hicolor
./kcookiejar
./keyrings
./kiten
./kmail2
./knewstuff3
./konsole
./kontact
./lftp
./local-mail
./local-mail/cur
./local-mail/new
./local-mail/tmp
./love
./love/not_tetris_2
./mc
./mc/mcedit
./mcomix
./mime
./mime/application
./mime/image
./mime/packages
./mime/text
./openttd
./openttd/ai
./openttd/baseset
./openttd/content_download
./openttd/game
./openttd/newgrf
./openttd/save
./openttd/scenario
./openttd/screenshot
./openttd/social_integration
./org.gnome.Evolution
./org.gnome.Evolution/mediakeys
./org.gnome.Evolution/storage
./phishingurl
./remmina
./rott
./rott/darkwar
./teamviewer15
./teamviewer15/TeamViewer
./teamviewer15/logfiles
./vlc
./webkitgtk
./webkitgtk/deviceidhashsalts
./webkitgtk/storage
./xorg

@Lgt2x

Lgt2x commented May 23, 2025

Copy link
Copy Markdown
Member

Steam uses a different version (see #9 ) for which we don't have the code, even though icculus ported some patches here.

I'm not against this idea either, but to ensure compatibility with steam, we will need to copy files over to the new location on launch, if we find that the steam directory has files and ours does not.

@jengelh

jengelh commented May 23, 2025

Copy link
Copy Markdown
Contributor Author

removed 2nd commit pertaining to D3_PREF_ORG.

@Lgt2x

Lgt2x commented May 23, 2025

Copy link
Copy Markdown
Member

@Jayman2000 is the remaining commit fine regarding your Nix-pkgs port? There may be some required action on your side for the update

@Lgt2x Lgt2x changed the title Use lower-case datadir and reduced-length pref dirs Use lower-case datadir May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants