Guard the external link launch in the reader view - #63
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces error handling when opening external links from the WebView in ReadableContentScreen.kt by catching ActivityNotFoundException and displaying a Toast message. The review feedback correctly suggests externalizing the hardcoded Toast message string to strings.xml to support localization.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| try { | ||
| context.startActivity(intent) | ||
| } catch (e: ActivityNotFoundException) { | ||
| Toast.makeText(context, "No app found to open this link", Toast.LENGTH_SHORT).show() |
There was a problem hiding this comment.
The user-facing string "No app found to open this link" is hardcoded. To support internationalization (i18n) and localization, this string should be defined in the strings.xml resource file and retrieved using context.getString().
1 participant
This wraps the external link launch in the reader view so the app no longer crashes when there is no app available to open the link.
Before, the link was passed to
startActivitydirectly, which throwsActivityNotFoundExceptionon a device with no handler. With this change the link still opens when a handler exists, and otherwise the exception is caught and a short message is shown.Closes #62.