Stop linking issues to upstream commetchat/commet (fixes #248)#249
Merged
Conversation
Upstream maintainer asked us (issue #248) to stop creating cross-reference notification spam in commetchat/commet. GitHub posts a "referenced" event into the upstream repo whenever an issue/PR/commit/comment contains the `commetchat/commet#N` slug-glued form or an upstream issue/PR URL. Root cause + fixes: - scripts/create_issues.py: drop the `UPSTREAM="commetchat/commet"` prefix that glued the slug onto each ref; emit inert backticked `#N` instead, so generated issue bodies never link upstream. This script minted the ~28 offending issues. - ROADMAP.md + CONTRIBUTING.md: add a "never link upstream" cross-reference policy; keep upstream tracker numbers as backticked context only. - In-app bug reporter (log page + fatal-error page): file reports into this fork (Deniel9204/MyCommet) instead of upstream. - About page Source Code / License links: point at this fork. - De-link stray upstream refs in code/doc comments. Existing already-posted references are de-linked separately via the API, and no git history is rewritten (the one already-fired commit reference cannot be retracted; fixing forward only).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #248 — upstream maintainer @Airyzz asked us to stop creating cross-reference notification spam in the upstream repo.
Cause
GitHub posts a "referenced" event into a target repo whenever an issue/PR/commit/comment contains the
owner/repo#Nslug-glued form or a full issue/PR URL. The roadmap automation did exactly that at scale:scripts/create_issues.pyprefixed every roadmap reference with the upstream slug and posted it into each generated issue body, pinging dozens of upstream issues.Changes
scripts/create_issues.py— drop theUPSTREAM = "commetchat/commet"prefix; emit inert backticked`#N`refs that never link upstream. (This script minted the offending issues.)ROADMAP.md+CONTRIBUTING.md— add a "never link upstream" cross-reference policy; keep upstream tracker numbers as backticked context only.git grep -nE 'commetchat/commet#[0-9]+'returns nothing outside the backticked policy examples.Not included (by design)
a03ff39a) cannot have its notification retracted, and a rewrite would break shared history for no benefit. Fixing forward only.Verification
create_issues.pybody generation verified to emit nocommetchat/commet#Nand no upstream URL.fvm flutter analyzeon the changed files on the host.