ci: grant release.yml contents:write (fix release asset upload)#247
Merged
Conversation
The v0.1.0 release built every platform successfully but every job failed at the "Upload to release" step with "Resource not accessible by integration": the workflow declared no permissions, so its GITHUB_TOKEN was read-only and actions/upload-release-asset couldn't attach assets. Add the workflow-level `permissions: contents: write` (same as benchmark.yml already uses). The dry runs missed this because they upload via actions/upload-artifact (no write needed), not the release-asset path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.1.0 release built all platforms but every job failed at Upload to release with
Resource not accessible by integration—release.ymlhad nopermissions:block, so the token was read-only. Addpermissions: contents: write(benchmark.yml already has it). Dry runs missed it because they useupload-artifact, not the release-asset upload.