Build debug-signed Android APK when no release keystore is configured#246
Merged
Conversation
The Android release jobs failed with "RangeError ... 0..1: 2": with no signing secrets (a fork without ANDROID_KEY_STORE_B64 / ANDROID_KEY_PASSWORD), the CI command becomes `--key_password --key_b64` with no values, and setup_android_release.dart indexed past the args. - setup_android_release.dart: make getArg bounds-safe, and skip writing key.properties when no keystore is provided (null/empty/leading "--"). - android/app/build.gradle: the release build now falls back to signingConfigs. debug when key.properties is absent, so it produces an installable (sideload-only) APK instead of an unsigned one. With a real keystore present it still release-signs exactly as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the Android release on the fork (no signing secrets) per the v0.1.0 release plan.
The release jobs failed with
RangeError ... 0..1: 2— empty signing secrets made the CI command--key_password --key_b64(no values) andsetup_android_release.dartindexed past the args.setup_android_release.dart:getArgis bounds-safe, and it skips writingkey.propertieswhen no keystore is provided.android/app/build.gradle: release build falls back tosigningConfigs.debugwhenkey.propertiesis absent → installable sideload-only APK instead of unsigned. With a real keystore it release-signs exactly as before.Found via the v0.1.0 release dry run.