Shared module soil moisture#935
Closed
SouthEndMusic wants to merge 14 commits into
Closed
Conversation
Collaborator
|
As just briefly mentioned to @SouthEndMusic , we may want to opt for low level sharing of functions (e.g. for each irrigation node). Just a thought, an idea. This way there is no dependence of Wflow structs and there is more flexibility on the side of Ribasim. Not sure how doable this is. |
Contributor
Author
|
Closing this as @HendrikKok and I came to the conclusion that for the prototype there are no changes required on the Wflow side. It makes more sense to build the 'shared library' (now more of a wrapper) in the Ribasim repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked PR in Ribasim: Deltares/Ribasim#3103