Skip to content

add agent skills structure used new structure to create compound structure PRD + issues#3075

Open
JohnRushKucharski wants to merge 8 commits into
mainfrom
agent-skills
Open

add agent skills structure used new structure to create compound structure PRD + issues#3075
JohnRushKucharski wants to merge 8 commits into
mainfrom
agent-skills

Conversation

@JohnRushKucharski

Copy link
Copy Markdown
Collaborator

Extra structures for copilot skills.

…cture PRD + issues

Co-authored-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings May 7, 2026 09:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds repository-local “agent skills” documentation under .github/skills/, along with supporting repo context docs (CONTEXT.md, AGENTS.md, PRD) and several example ribasim.toml configs for docs/tutorial datasets.

Changes:

  • Added a structured set of agent skill instructions (triage, TDD, diagnose, fix-issue, PRD/issues breakdown, etc.) under .github/skills/.
  • Added domain/context and process documentation (CONTEXT.md, AGENTS.md, issue-tracker/labels docs) plus a first PRD for Compound Structures (MVP).
  • Added ribasim.toml files to multiple docs datasets (guide + crystal-basin tutorial).

Reviewed changes

Copilot reviewed 37 out of 117 changed files in this pull request and generated 16 comments.

Show a summary per file
File Description
docs/tutorial/crystal-basin/Crystal-1/ribasim.toml Adds tutorial model config (time window, CRS, I/O dirs, version).
docs/tutorial/crystal-basin/Crystal-2/ribasim.toml Adds tutorial model config (time window, CRS, I/O dirs, version).
docs/tutorial/crystal-basin/Crystal-3/ribasim.toml Adds tutorial model config (time window, CRS, I/O dirs, version).
docs/guide/data/basic/ribasim.toml Adds basic guide dataset config.
docs/guide/data/level_range/ribasim.toml Adds guide dataset config + solver tolerances section.
docs/guide/data/local_pidcontrolled_cascade/ribasim.toml Adds guide dataset config.
docs/guide/data/outlet_continuous_control/ribasim.toml Adds guide dataset config.
docs/guide/data/pid_control/ribasim.toml Adds guide dataset config.
CONTEXT.md Introduces domain glossary/context for “Compound Structure”, Nodes, Links, protocol concepts.
AGENTS.md Adds an entrypoint doc pointing to issue tracker/labels/domain docs.
.github/skills/zoom-out/SKILL.md Adds a “zoom-out” skill prompt.
.github/skills/triage/SKILL.md Adds an issue triage workflow skill (roles, state machine, templates).
.github/skills/triage/OUT-OF-SCOPE.md Documents out-of-scope knowledge base conventions for triage.
.github/skills/triage/AGENT-BRIEF.md Adds guidance/template for writing durable agent briefs.
.github/skills/to-prd/SKILL.md Adds a skill to synthesize a PRD from conversation context.
.github/skills/to-issues/SKILL.md Adds a skill to break plans/PRDs into vertical-slice issues.
.github/skills/tdd/tests.md Adds examples of good/bad tests for the TDD skill.
.github/skills/tdd/SKILL.md Adds the TDD workflow guidance (vertical slices, red/green/refactor).
.github/skills/tdd/refactoring.md Adds refactor-candidate checklist for TDD loop.
.github/skills/tdd/mocking.md Adds mocking guidance (mock only at system seams).
.github/skills/tdd/interface-design.md Adds testability-focused interface design guidance.
.github/skills/tdd/deep-modules.md Adds deep-module vs shallow-module guidance.
.github/skills/ralph-loop/SKILL.md Adds orchestration skill for looping over “ready-for-agent” issues.
.github/skills/improve-codebase-architecture/SKILL.md Adds architecture improvement skill using shared vocabulary.
.github/skills/improve-codebase-architecture/LANGUAGE.md Defines the required architecture vocabulary for that skill.
.github/skills/improve-codebase-architecture/INTERFACE-DESIGN.md Adds a “design it twice” interface exploration process.
.github/skills/improve-codebase-architecture/DEEPENING.md Adds dependency categories + testing strategy for deepening.
.github/skills/grill-with-docs/SKILL.md Adds a “grill-with-docs” interviewing + inline-doc-update skill.
.github/skills/grill-with-docs/CONTEXT-FORMAT.md Defines expected CONTEXT.md format for grilling sessions.
.github/skills/grill-with-docs/ADR-FORMAT.md Defines ADR format/location guidance for grilling sessions.
.github/skills/fix-issue/SKILL.md Adds an end-to-end AFK issue fixing workflow skill.
.github/skills/diagnose/SKILL.md Adds a disciplined diagnosis workflow skill.
.github/skills/diagnose/scripts/hitl-loop.template.sh Adds a human-in-the-loop repro loop script template.
.github/prd/0001-compound-structures-mvp.md Adds the first PRD document for Compound Structures MVP.
.github/agents/triage-labels.md Adds canonical triage-role → label mapping doc.
.github/agents/issue-tracker.md Documents issue tracker operations and conventions (gh CLI).
.github/agents/domain.md Documents how skills should consume domain docs + ADRs.

Comment thread AGENTS.md
Comment thread .github/skills/fix-issue/SKILL.md
Comment thread .github/agents/issue-tracker.md
Comment thread .github/skills/triage/SKILL.md Outdated
Comment thread .github/skills/to-prd/SKILL.md Outdated
Comment thread docs/guide/data/local_pidcontrolled_cascade/ribasim.toml Outdated
Comment thread docs/guide/data/outlet_continuous_control/ribasim.toml Outdated
Comment thread docs/guide/data/pid_control/ribasim.toml Outdated
Comment thread .github/agents/domain.md
Comment thread .github/skills/to-prd/SKILL.md Outdated
edit to triage skill.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Deltares/Ribasim/sessions/8378b8c3-e5c1-421a-b709-58bd75bd9544

Co-authored-by: JohnRushKucharski <26230348+JohnRushKucharski@users.noreply.github.com>
JohnRushKucharski and others added 2 commits May 7, 2026 12:29
removed useless reference from triage skill.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Deltares/Ribasim/sessions/91ec0f9c-448b-47ec-a669-cd0264da31ba

Co-authored-by: JohnRushKucharski <26230348+JohnRushKucharski@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Deltares/Ribasim/sessions/d729b152-0037-464e-aefa-d9bf5bd1eee5

Co-authored-by: JohnRushKucharski <26230348+JohnRushKucharski@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Deltares/Ribasim/sessions/a0e317e3-c2a9-4b6d-b65e-89529d0b8c91

Co-authored-by: JohnRushKucharski <26230348+JohnRushKucharski@users.noreply.github.com>

Copilot AI commented May 7, 2026

Copy link
Copy Markdown
Contributor

@JohnRushKucharski Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub.

You can ask me to try again later by mentioning me in a new comment.

If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: 7031cfd2-928e-42ba-bc61-ddc944e7f51b

Sorry for the inconvenience!

remove useless reference to another skill.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants