add agent skills structure used new structure to create compound structure PRD + issues#3075
Open
JohnRushKucharski wants to merge 8 commits into
Open
add agent skills structure used new structure to create compound structure PRD + issues#3075JohnRushKucharski wants to merge 8 commits into
JohnRushKucharski wants to merge 8 commits into
Conversation
…cture PRD + issues Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds repository-local “agent skills” documentation under .github/skills/, along with supporting repo context docs (CONTEXT.md, AGENTS.md, PRD) and several example ribasim.toml configs for docs/tutorial datasets.
Changes:
- Added a structured set of agent skill instructions (triage, TDD, diagnose, fix-issue, PRD/issues breakdown, etc.) under
.github/skills/. - Added domain/context and process documentation (
CONTEXT.md,AGENTS.md, issue-tracker/labels docs) plus a first PRD for Compound Structures (MVP). - Added
ribasim.tomlfiles to multiple docs datasets (guide + crystal-basin tutorial).
Reviewed changes
Copilot reviewed 37 out of 117 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/tutorial/crystal-basin/Crystal-1/ribasim.toml | Adds tutorial model config (time window, CRS, I/O dirs, version). |
| docs/tutorial/crystal-basin/Crystal-2/ribasim.toml | Adds tutorial model config (time window, CRS, I/O dirs, version). |
| docs/tutorial/crystal-basin/Crystal-3/ribasim.toml | Adds tutorial model config (time window, CRS, I/O dirs, version). |
| docs/guide/data/basic/ribasim.toml | Adds basic guide dataset config. |
| docs/guide/data/level_range/ribasim.toml | Adds guide dataset config + solver tolerances section. |
| docs/guide/data/local_pidcontrolled_cascade/ribasim.toml | Adds guide dataset config. |
| docs/guide/data/outlet_continuous_control/ribasim.toml | Adds guide dataset config. |
| docs/guide/data/pid_control/ribasim.toml | Adds guide dataset config. |
| CONTEXT.md | Introduces domain glossary/context for “Compound Structure”, Nodes, Links, protocol concepts. |
| AGENTS.md | Adds an entrypoint doc pointing to issue tracker/labels/domain docs. |
| .github/skills/zoom-out/SKILL.md | Adds a “zoom-out” skill prompt. |
| .github/skills/triage/SKILL.md | Adds an issue triage workflow skill (roles, state machine, templates). |
| .github/skills/triage/OUT-OF-SCOPE.md | Documents out-of-scope knowledge base conventions for triage. |
| .github/skills/triage/AGENT-BRIEF.md | Adds guidance/template for writing durable agent briefs. |
| .github/skills/to-prd/SKILL.md | Adds a skill to synthesize a PRD from conversation context. |
| .github/skills/to-issues/SKILL.md | Adds a skill to break plans/PRDs into vertical-slice issues. |
| .github/skills/tdd/tests.md | Adds examples of good/bad tests for the TDD skill. |
| .github/skills/tdd/SKILL.md | Adds the TDD workflow guidance (vertical slices, red/green/refactor). |
| .github/skills/tdd/refactoring.md | Adds refactor-candidate checklist for TDD loop. |
| .github/skills/tdd/mocking.md | Adds mocking guidance (mock only at system seams). |
| .github/skills/tdd/interface-design.md | Adds testability-focused interface design guidance. |
| .github/skills/tdd/deep-modules.md | Adds deep-module vs shallow-module guidance. |
| .github/skills/ralph-loop/SKILL.md | Adds orchestration skill for looping over “ready-for-agent” issues. |
| .github/skills/improve-codebase-architecture/SKILL.md | Adds architecture improvement skill using shared vocabulary. |
| .github/skills/improve-codebase-architecture/LANGUAGE.md | Defines the required architecture vocabulary for that skill. |
| .github/skills/improve-codebase-architecture/INTERFACE-DESIGN.md | Adds a “design it twice” interface exploration process. |
| .github/skills/improve-codebase-architecture/DEEPENING.md | Adds dependency categories + testing strategy for deepening. |
| .github/skills/grill-with-docs/SKILL.md | Adds a “grill-with-docs” interviewing + inline-doc-update skill. |
| .github/skills/grill-with-docs/CONTEXT-FORMAT.md | Defines expected CONTEXT.md format for grilling sessions. |
| .github/skills/grill-with-docs/ADR-FORMAT.md | Defines ADR format/location guidance for grilling sessions. |
| .github/skills/fix-issue/SKILL.md | Adds an end-to-end AFK issue fixing workflow skill. |
| .github/skills/diagnose/SKILL.md | Adds a disciplined diagnosis workflow skill. |
| .github/skills/diagnose/scripts/hitl-loop.template.sh | Adds a human-in-the-loop repro loop script template. |
| .github/prd/0001-compound-structures-mvp.md | Adds the first PRD document for Compound Structures MVP. |
| .github/agents/triage-labels.md | Adds canonical triage-role → label mapping doc. |
| .github/agents/issue-tracker.md | Documents issue tracker operations and conventions (gh CLI). |
| .github/agents/domain.md | Documents how skills should consume domain docs + ADRs. |
edit to triage skill. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Deltares/Ribasim/sessions/8378b8c3-e5c1-421a-b709-58bd75bd9544 Co-authored-by: JohnRushKucharski <26230348+JohnRushKucharski@users.noreply.github.com>
removed useless reference from triage skill. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Deltares/Ribasim/sessions/91ec0f9c-448b-47ec-a669-cd0264da31ba Co-authored-by: JohnRushKucharski <26230348+JohnRushKucharski@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Deltares/Ribasim/sessions/d729b152-0037-464e-aefa-d9bf5bd1eee5 Co-authored-by: JohnRushKucharski <26230348+JohnRushKucharski@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Deltares/Ribasim/sessions/a0e317e3-c2a9-4b6d-b65e-89529d0b8c91 Co-authored-by: JohnRushKucharski <26230348+JohnRushKucharski@users.noreply.github.com>
Contributor
|
@JohnRushKucharski Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
remove useless reference to another skill. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extra structures for copilot skills.