Skip to content

Add 'edit_head_line' method to D-Stability Waternet - #46

Open
yida-tao wants to merge 9 commits into
Deltares:masterfrom
yida-tao:edit_headline
Open

Add 'edit_head_line' method to D-Stability Waternet#46
yida-tao wants to merge 9 commits into
Deltares:masterfrom
yida-tao:edit_headline

Conversation

@yida-tao

Copy link
Copy Markdown
Contributor

No description provided.

@carloslubbers

Copy link
Copy Markdown
Contributor

Thanks for your contribution, the added method looks good! Could you add a small test verifying it's behavior in the file tests/models/dstability/test_waternets.py? You can add it right below test_add_head_line in a similar style, assert'ing that your method correctly updates the head line properties

@carloslubbers carloslubbers linked an issue Nov 14, 2022 that may be closed by this pull request
@carloslubbers carloslubbers changed the title Update internal.py Add 'edit_head_line' method to D-Stability Waternet Nov 14, 2022
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

edit headline

2 participants