240 fix connect layers - #241
Open
KentropDevelopment wants to merge 2 commits into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #240
I realise that this method is less fast than the previous one. The original takes a union of to linestrings and polygonises the result. The current method loops through all line parts of adjacent polygons to find the line piece to add the point to. It however only does that for points that should be added (side note: or points which are within tolerance distance of an existing vertex). So if the user adds most of the points then the performance shouldn't be an issue. Though this might affect calculation times doing probabilistic analysis like MC(IS) a bit, if this is not taken into account.
Now that I am writing this, maybe a two-step method combining the former and the current method would solve this. First try the fast method, if it fails, take the brute-force method.
Like to hear your opinion.