Enforced diagnostics - #95
Draft
BarryNorfolk wants to merge 11 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Adds .editorconfigs to try and catch code style/general improvements to code conformity to help maintainers and contributors.
Technical details
A few things I've already ignored since we use them a hell of a lot around RT/Upstream code, like no braces on if statements, but other ones I think are still valid to enforce (Like using return values).
I'd like to get two things sorted first though:
dotnet format --verify-no-changes **/_DVA/**/*.cstask to validate output.IDE1006error onnamespace Content.{Shared,Server,Client}._DVAwhere the underscore in front of _DVA is treated as an error and "unexpected". I think this might come from upstreams' .editorconfig but need to track it down.Licensing