ci: fix latest.json race condition in release workflow#60
Merged
Conversation
…dition All three platform builds were uploading latest.json in parallel; concurrent delete+re-upload of the same asset caused 404 errors. max-parallel:1 makes each platform run sequentially so each job merges its signatures into the existing latest.json without conflict. Releases take ~3x longer but are reliable. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Move removeMessage before the await in deleteMessage so the message disappears from the UI instantly rather than waiting for the Supabase round trip (which can take >10s in CI, causing the E2E assertion to time out) - Switch Add Friend search from fill() to click()+keyboard.type() so each keystroke fires React's onChange on the controlled input reliably Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- clickByTitle: use locator.dispatchEvent('click') instead of page.evaluate
element.click() — dispatchEvent bypasses viewport bounds without the silent
no-op risk when querySelector returns null
- Widen timeout on tab bar button waits from default 5s to 10s so slow CI
renders don't cause false failures
- setInputValue: native value setter + single input event fires exactly one
Supabase query for the Add Friend search, eliminating the race condition
where keyboard.type fired 10 concurrent queries that could overwrite each other
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
latest.json(the auto-updater manifest) simultaneouslyNot Found - update-a-release-asset)Fix
Add
max-parallel: 1to the build matrix strategy. Each platform now runs sequentially: Windows → macOS → Linux. Each job reads the existinglatest.jsonfrom the draft release and merges in its own platform's signatures, so the finallatest.jsoncontains all three platforms correctly.Trade-off: releases take ~3x longer (~45 min instead of ~15 min), but they no longer fail randomly.
Test plan
latest.jsoncontains signatures for all three platforms🤖 Generated with Claude Code