You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is the broad mechanical rename that makes today's runtime sample-shaped before the typed WAL, heterogeneous experiment API, and candidate-pool semantics land. It does not try to delete the definition runtime bridge yet; it makes the naming and state-test baseline possible for the later PRs.
Moves runtime modules to sample vocabulary, including sample_records.py, sample_lifecycle.py, and sample_identity.py.
Replaces REST routes/runs.py with routes/samples.py and mounts samples_router.
Moves dashboard route/state from /run/[runId] to /samples/[sampleId], with component/library renames under components/sample and lib/sample-state.
Moves CLI surface from ergon run ... to ergon sample ... under ergon_cli/domains/samples.
Updates examples/observability to emit /samples/{sample_id} dashboard URLs and ergon sample status.
Gotchas / Review Risks
SampleRecord.definition_id intentionally remains. It is still the launch/source bridge until the definition-runtime deletion PR.
Compatibility aliases remain in sample_records.py: create_run, cancel_run, and latest_run_for_definition.
Generic graph mutation and annotation tables are only renamed here; PR 01 replaces them with typed sample WAL tables.
Some frontend/internal names remain run-shaped after this PR, such as loadRunSnapshot, RunSummary, RunsPage, and “Run Index”. Later PRs/remediation continue that cleanup.
RolloutBatchRun still exists here, although its FK becomes sample_id; rollout-batch sample membership is PR 02.
Cleaned Later
PR 01 replaces the generic mutation WAL with typed sample WAL.
PR 02 replaces rollout-batch run membership with sample membership.
PRs 03-05 add public Sample / Environment / Experiment authoring and materialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review Guide
Stack position: PR 00, base
dev, headcodex/episode-sample-pr00.Implements RFC Docs
01-exec-summary.md: starts the runtime move from definition/run identity to sample identity.03b-implementation-churn.md: prereq PR 00, runtime vocabulary and state tests.03c-postgres-table-inventory.md:samples.idbecomes the runtime root.09-implementation-plan/01-pr-00-runtime-vocabulary-and-state-tests.md.Why This PR Exists
This is the broad mechanical rename that makes today's runtime sample-shaped before the typed WAL, heterogeneous experiment API, and candidate-pool semantics land. It does not try to delete the definition runtime bridge yet; it makes the naming and state-test baseline possible for the later PRs.
What Actually Changes
RunRecord->SampleRecord, tableruns->samples.RunTaskExecution->SampleTaskAttempt, tablerun_task_executions->sample_task_attempts.RunTaskEvaluation->SampleTaskEvaluation, tablerun_task_evaluations->sample_task_evaluations.RunResource->SampleResource, tablerun_resources->sample_resources.RunStatus->SampleStatus,RunResourceKind->SampleResourceKind.sample_records.py,sample_lifecycle.py, andsample_identity.py.routes/runs.pywithroutes/samples.pyand mountssamples_router./run/[runId]to/samples/[sampleId], with component/library renames undercomponents/sampleandlib/sample-state.ergon run ...toergon sample ...underergon_cli/domains/samples./samples/{sample_id}dashboard URLs andergon sample status.Gotchas / Review Risks
SampleRecord.definition_idintentionally remains. It is still the launch/source bridge until the definition-runtime deletion PR.sample_records.py:create_run,cancel_run, andlatest_run_for_definition.loadRunSnapshot,RunSummary,RunsPage, and “Run Index”. Later PRs/remediation continue that cleanup.RolloutBatchRunstill exists here, although its FK becomessample_id; rollout-batch sample membership is PR 02.Cleaned Later
Sample/Environment/Experimentauthoring and materialization.Validation Notes
Key guards include
test_sample_runtime_vocabulary.py,test_sample_vocabulary_boundaries.py, sample route/read-model tests, sample CLI tests, and dashboard sample snapshot/delta contract tests.