Add CI: tests and static analysis on push/PR#14
Merged
Conversation
Add a GitHub Actions workflow that runs the project's existing quality gates on push to main and on pull requests: - static-analysis: tsc --noEmit (strict) and a generated-types drift check that fails if src/generated is out of date with the schema (generated files are committed and must never be hand-edited) - test: vitest (npm test) Uses Node 22 with npm cache; concurrency cancels superseded runs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UFPpc84i8VimSTnWwGkBfW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a GitHub Actions workflow (
.github/workflows/ci.yml) that runs the project's existing quality gates on every push tomainand on every pull request. There was no CI before this.Jobs
npm run typecheck—tsc --noEmitin strict mode (the project's actual static-analysis gate).npm run genand fails ifsrc/generateddiffers from what's committed. Generated files are checked in and must never be hand-edited (perCLAUDE.md), so this guards against the schema andsrc/generated/types.tsdrifting apart.npm test— vitest (vitest run), including fixture validation and coverage-row protection.Details
@types/node ^22),npm ciwith npm cache.concurrencycancels superseded runs on the same ref.permissions: contents: read— least privilege.Notes
The "lint" referenced in the SPEC-05 docs is the domain confidence→band-width lint (part of the knowledge service), not a code linter — no ESLint config exists in the repo, so this workflow wires up the gates that already exist rather than introducing new tooling. All three checks pass locally against the current tree.
🤖 Generated with Claude Code
Generated by Claude Code