Skip to content

(Idea) feature: remove entry server and use same worker server to entry #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YuriCat wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

(Idea) feature: remove entry server and use same worker server to entry #259

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2529cd7
feature: remove entry server and use same worker server to entry
YuriCat Jan 30, 2022
704f501
Merge develop
YuriCat Mar 23, 2022
95d3551
Merge develop
YuriCat Apr 27, 2022
5240658
Merge branch 'develop' into feature/remove_entry_server_but_leave_entry
YuriCat Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 15 additions & 19 deletions handyrl/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,36 +197,31 @@ def __init__(self, args):

def run(self):
# prepare listening connections
def entry_server(port):
print('started entry server %d' % port)
conn_acceptor = accept_socket_connections(port=port)
while True:
conn = next(conn_acceptor)
worker_args = conn.recv()
print('accepted connection from %s!' % worker_args['address'])
worker_args['base_worker_id'] = self.total_worker_count
self.total_worker_count += worker_args['num_parallel']
args = copy.deepcopy(self.args)
args['worker'] = worker_args
conn.send(args)
conn.close()
print('finished entry server')

def worker_server(port):
print('started worker server %d' % port)
conn_acceptor = accept_socket_connections(port=port)
while True:
conn = next(conn_acceptor)
self.add_connection(conn)
type, worker_args = conn.recv()
if type == 'entry':
print('accepted connection from %s!' % worker_args['address'])
worker_args['base_worker_id'] = self.total_worker_count
self.total_worker_count += worker_args['num_parallel']
args = copy.deepcopy(self.args)
args['worker'] = worker_args
conn.send(args)
conn.close()
else:
self.add_connection(conn)
print('finished worker server')

threading.Thread(target=entry_server, args=(9999,), daemon=True).start()
# use thread list of super class
threading.Thread(target=worker_server, args=(9998,), daemon=True).start()


def entry(worker_args):
conn = connect_socket_connection(worker_args['server_address'], 9999)
conn.send(worker_args)
conn = connect_socket_connection(worker_args['server_address'], 9998)
conn.send(('entry', worker_args))
args = conn.recv()
conn.close()
return args
Expand All @@ -250,6 +245,7 @@ def run(self):
try:
for i in range(self.args['num_gathers']):
conn = connect_socket_connection(self.args['server_address'], 9998)
conn.send(('worker', None))
p = mp.Process(target=gather_loop, args=(args, conn, i))
p.start()
conn.close()
Expand Down