Support windows#5
Conversation
|
What is the benefit of this exactly? If I see correctly, in the windows file you removed the headless option, thus only non-headless is supported here, which already should work as is. |
As with #2 , when I "go get" on Windows, I get the error "type *syscall.SysProcAttr has no field or method Pdeathsig". To prevent this, I've separated the files into Windows and Unix. |
|
Ah I see. This quite a heavy workaround, lets first see if we can remove |
|
The same issue exists on MacOS |
|
I've submitted a PR ( #7 ) to build both on MacOS and Windows(and linux). Unless there is something I'm missing I believe this PR is toast as it copies unnecessary code that does not work anyway (i.e. Xvfb is not supported on windows ). |
Separating Unix files from Windows files.