Input-stack + workstation-audit evidence bundles + diagnostic tooling#47
Merged
Conversation
…es; refine tooling - Reports/haptic-touchpad/**: repro/trace/firmware/pointer evidence bundles. - Reports/hid-io-triage-20260606-165046/**: HID/IO triage capture. - input-stack hid-deep-06 + processlasso-governor-watchdog.json refresh. - Tools/InputDiagnostics: Test-KeyInput + Watch-InputGlitch refinements. - Tests/InputDiagnostics + boot.TODO.md ledger update for the reliability surface. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…IDIA dual-GPU tools New PowerShell tools referenced by the InputDiagnostics README: - Export-HapticTouchpadReproBundle.ps1, Start-HapticTouchpadTrace.ps1, Watch-HapticTouchpadInput.ps1 (haptic touchpad repro/trace/monitor) - Get-SenselFirmwareState.ps1, Repair-TouchpadPowerManagement.ps1 - Test-NvidiaDualGpuDriverHealth.ps1 (internal + eGPU driver health) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…dles - Reports/workstation-audit-20260606-124859/**: full audit incl. SUMMARY.md (NVIDIA RTX 2000 Ada Code 31 finding cross-linked from the input-stack work). - Reports/power-maintenance-20260606-165916/**: power maintenance capture. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive diagnostic reports, test updates, and utility scripts under Reports/ to troubleshoot haptic touchpad stickiness, power management, and repository configuration drift on a ThinkPad P1 Gen 7 workstation. The review feedback highlights several critical PowerShell scripting improvements: wrapping Add-Type definitions in conditional checks to prevent re-definition errors in the same session, explicitly clearing $global:LASTEXITCODE before executing script blocks to avoid stale exit codes, checking Pester's FailedCount to ensure test failures trigger a non-zero exit code, and adding the -PassThru parameter to Disable-ScheduledTask so the modified task objects can be successfully captured and piped.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33f673d80b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR primarily lands a set of workstation/input-stack diagnostic evidence bundles under Reports/ and expands the Tools/InputDiagnostics toolkit (plus Pester coverage) to support ongoing investigation of intermittent Shift/touchpad/input reliability issues—particularly around haptic touchpad, power-management, and dual-GPU NVIDIA driver split health.
Changes:
- Updated/expanded input-diagnostics tooling (incl. raising PowerShell requirement for
Watch-InputGlitch.ps1, refiningTest-KeyInput.ps1, and addingTest-NvidiaDualGpuDriverHealth.ps1). - Expanded
Tests/InputDiagnostics/InputDiagnostics.Tests.ps1to cover new/expanded tools and safety constraints. - Added substantial “evidence bundle” artifacts under
Reports/and updatedboot.TODO.mdwith new investigation/remediation ledger entries.
Reviewed changes
Copilot reviewed 122 out of 141 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| Tools/InputDiagnostics/Watch-InputGlitch.ps1 | Raises required PowerShell version to 7.0 for the glitch ledger tool. |
| Tools/InputDiagnostics/Test-NvidiaDualGpuDriverHealth.ps1 | Adds read-only NVIDIA internal+eGPU driver health evidence capture + -FailOnIssue. |
| Tools/InputDiagnostics/Test-KeyInput.ps1 | Minor header + P/Invoke definition refinements for key event capture. |
| Tests/InputDiagnostics/InputDiagnostics.Tests.ps1 | Adds/updates Pester assertions for the expanded InputDiagnostics toolkit. |
| Reports/workstation-audit-20260606-124859/touchpad-power-fix-20260606.md | Documents the touchpad power-management fix application + rollback + validation. |
| Reports/workstation-audit-20260606-124859/Run-RepoFixValidation.ps1 | Adds a focused validation runner for the repo-fix pass. |
| Reports/workstation-audit-20260606-124859/Run-InputDiagnosticsValidation.ps1 | Adds a helper to run InputDiagnostics Pester validation from the report bundle. |
| Reports/workstation-audit-20260606-124859/repo-fix-validation-20260606/summary.json | Captures validation results from the repo-fix pass. |
| Reports/workstation-audit-20260606-124859/repo-fix-pass-20260606/winget-nvidia-upgrades.txt | Captures winget NVIDIA upgrade check output. |
| Reports/workstation-audit-20260606-124859/repo-fix-pass-20260606/winget-lenovo-upgrades.txt | Captures winget Lenovo upgrade check output. |
| Reports/workstation-audit-20260606-124859/repo-fix-pass-20260606/recent-input-events.txt | Captures relevant recent event log entries for input/driver issues. |
| Reports/workstation-audit-20260606-124859/repo-fix-pass-20260606/nvidia-app-processes.txt | Captures running NVIDIA-related processes snapshot. |
| Reports/workstation-audit-20260606-124859/repo-fix-pass-20260606/manifest.json | Adds manifest metadata for the repo-fix pass evidence directory. |
| Reports/workstation-audit-20260606-124859/repo-fix-pass-20260606/cargo-tools-module-files.txt | Captures local CargoTools module file inventory snapshot. |
| Reports/workstation-audit-20260606-124859/repo-fix-pass-20260606/cargo-tools-build-environment.txt | Captures Rust build environment snapshot. |
| Reports/workstation-audit-20260606-124859/hid-io-regression-triage-20260606.md | Adds HID/IO regression triage write-up and recommended next actions. |
| Reports/workstation-audit-20260606-124859/Disable-StaleOneDriveTasks.ps1 | Adds a script that disables specific OneDrive tasks (mutating). |
| Reports/workstation-audit-20260606-124859/Disable-NonPrimaryOneDriveTasks.ps1 | Adds a script that disables non-primary OneDrive tasks (mutating). |
| Reports/workstation-audit-20260606-124859/Collect-RepoFixPassEvidence.ps1 | Adds a collector script for repo-fix pass evidence (mostly read-only capture). |
| Reports/workstation-audit-20260606-124859/Collect-DirectPassEvidence.ps1 | Adds a broad workstation “direct pass” evidence collection script. |
| Reports/workstation-audit-20260606-124859/Analyze-DirectPassEvidence.ps1 | Adds local analysis script to summarize collected direct-pass evidence. |
| Reports/processlasso-governor-watchdog.json | Updates Process Lasso governor watchdog status timestamps/details. |
| Reports/power-maintenance-20260606-165916/wake.txt | Adds wake timer / wake-armed device capture output. |
| Reports/power-maintenance-20260606-165916/sleepstudy-command.txt | Adds sleepstudy command output (path to generated report). |
| Reports/power-maintenance-20260606-165916/requests.txt | Adds powercfg /requests capture output. |
| Reports/power-maintenance-20260606-165916/energy-command.txt | Adds powercfg /energy command summary output. |
| Reports/input-stack-investigation-20260606/hid-deep-06-input-services.txt | Updates captured input services evidence text. |
| Reports/hid-io-triage-20260606-165046/summary.json | Adds HID/IO triage summary JSON artifact. |
| Reports/hid-io-triage-20260606-165046/powercfg.json | Adds powercfg captures as structured JSON. |
| Reports/hid-io-triage-20260606-165046/mspower-device-enable.json | Adds MSPower_DeviceEnable snapshot JSON. |
| Reports/hid-io-triage-20260606-165046/Microsoft-Windows-UserPnp_DeviceInstall.json | Adds UserPnp/DeviceInstall log JSON evidence. |
| Reports/haptic-touchpad/trace-20260606-165443/manifest.json | Adds trace manifest JSON for haptic touchpad ETW capture. |
| Reports/haptic-touchpad/trace-20260606-165443/logman-commands.txt | Adds captured logman command transcript for trace session. |
| Reports/haptic-touchpad/trace-20260606-161752/manifest.json | Adds trace manifest JSON for haptic touchpad ETW capture. |
| Reports/haptic-touchpad/trace-20260606-161752/logman-commands.txt | Adds captured logman command transcript for trace session. |
| Reports/haptic-touchpad/trace-20260606-155942/manifest.json | Adds trace manifest JSON for haptic touchpad ETW capture. |
| Reports/haptic-touchpad/trace-20260606-155942/logman-commands.txt | Adds captured logman command transcript for trace session. |
| Reports/haptic-touchpad/pointer-20260606-160616/pointer-input.json | Adds a pointer-input self-test JSON artifact. |
| Reports/haptic-touchpad/firmware-20260606-155907/README.md | Adds firmware state README evidence (needs target ID fix). |
| Reports/haptic-touchpad/firmware-20260606-155821/README.md | Adds firmware state README evidence (needs target ID fix). |
| Reports/haptic-touchpad/firmware-20260606-155806/README.md | Adds firmware state README evidence (needs target ID fix). |
| Reports/haptic-touchpad/bundle-20260606-164913/symptom-log.jsonl | Adds symptom ledger snapshot for repro bundle. |
| Reports/haptic-touchpad/bundle-20260606-164913/services.json | Adds services snapshot for repro bundle. |
| Reports/haptic-touchpad/bundle-20260606-164913/README.md | Adds repro bundle README. |
| Reports/haptic-touchpad/bundle-20260606-164913/processes.json | Adds process census snapshot for repro bundle. |
| Reports/haptic-touchpad/bundle-20260606-164913/precision-touchpad-settings.json | Adds Precision Touchpad registry snapshot. |
| Reports/haptic-touchpad/bundle-20260606-164913/manifest.json | Adds repro bundle manifest JSON. |
| Reports/haptic-touchpad/bundle-20260606-164913/input-devices.json | Adds PnP input device snapshot JSON. |
| Reports/haptic-touchpad/bundle-20260606-164913/firmware/README.md | Adds firmware README in repro bundle (needs target ID fix). |
| Reports/haptic-touchpad/bundle-20260606-164913/events-Application.json | Adds Application event evidence JSON. |
| Reports/haptic-touchpad/bundle-20260606-164913/device-powerdown-state.json | Adds device powerdown-state evidence JSON. |
| Reports/haptic-touchpad/bundle-20260606-163147/symptom-log.jsonl | Adds symptom ledger snapshot for repro bundle. |
| Reports/haptic-touchpad/bundle-20260606-163147/services.json | Adds services snapshot for repro bundle. |
| Reports/haptic-touchpad/bundle-20260606-163147/README.md | Adds repro bundle README. |
| Reports/haptic-touchpad/bundle-20260606-163147/processes.json | Adds process census snapshot for repro bundle. |
| Reports/haptic-touchpad/bundle-20260606-163147/precision-touchpad-settings.json | Adds Precision Touchpad registry snapshot. |
| Reports/haptic-touchpad/bundle-20260606-163147/manifest.json | Adds repro bundle manifest JSON. |
| Reports/haptic-touchpad/bundle-20260606-163147/input-devices.json | Adds PnP input device snapshot JSON. |
| Reports/haptic-touchpad/bundle-20260606-163147/firmware/README.md | Adds firmware README in repro bundle (needs target ID fix). |
| Reports/haptic-touchpad/bundle-20260606-163147/events-Application.json | Adds Application event evidence JSON. |
| Reports/haptic-touchpad/bundle-20260606-163147/device-powerdown-state.json | Adds device powerdown-state evidence JSON. |
| Reports/haptic-touchpad/bundle-20260606-161750/symptom-log.jsonl | Adds symptom ledger snapshot for repro bundle. |
| Reports/haptic-touchpad/bundle-20260606-161750/services.json | Adds services snapshot for repro bundle. |
| Reports/haptic-touchpad/bundle-20260606-161750/README.md | Adds repro bundle README. |
| Reports/haptic-touchpad/bundle-20260606-161750/processes.json | Adds process census snapshot for repro bundle. |
| Reports/haptic-touchpad/bundle-20260606-161750/precision-touchpad-settings.json | Adds Precision Touchpad registry snapshot. |
| Reports/haptic-touchpad/bundle-20260606-161750/manifest.json | Adds repro bundle manifest JSON. |
| Reports/haptic-touchpad/bundle-20260606-161750/input-devices.json | Adds PnP input device snapshot JSON. |
| Reports/haptic-touchpad/bundle-20260606-161750/firmware/README.md | Adds firmware README in repro bundle (needs target ID fix). |
| Reports/haptic-touchpad/bundle-20260606-161750/device-powerdown-state.json | Adds device powerdown-state evidence JSON. |
| Reports/haptic-touchpad/bundle-20260606-160153/symptom-log.jsonl | Adds symptom ledger snapshot for repro bundle. |
| Reports/haptic-touchpad/bundle-20260606-160153/services.json | Adds services snapshot for repro bundle. |
| Reports/haptic-touchpad/bundle-20260606-160153/README.md | Adds repro bundle README. |
| Reports/haptic-touchpad/bundle-20260606-160153/processes.json | Adds process census snapshot for repro bundle. |
| Reports/haptic-touchpad/bundle-20260606-160153/precision-touchpad-settings.json | Adds Precision Touchpad registry snapshot. |
| Reports/haptic-touchpad/bundle-20260606-160153/manifest.json | Adds repro bundle manifest JSON. |
| Reports/haptic-touchpad/bundle-20260606-160153/input-devices.json | Adds PnP input device snapshot JSON. |
| Reports/haptic-touchpad/bundle-20260606-160153/firmware/README.md | Adds firmware README in repro bundle (needs target ID fix). |
| Reports/haptic-touchpad/bundle-20260606-160153/device-powerdown-state.json | Adds device powerdown-state evidence JSON. |
| boot.TODO.md | Extends the workstation remediation ledger with 2026-06-06 entries and updated next steps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flushes pending pre-existing diagnostic evidence + tooling (committed at the user's request; not authored this session).
Commits
docs(input-stack)— haptic-touchpad + hid-io-triage evidence bundles; hid-deep-06 + processlasso refresh; Test-KeyInput/Watch-InputGlitch refinements; Tests/InputDiagnostics + boot.TODO.md ledger.feat(input-diagnostics)— 6 new PS tools (haptic repro/trace/monitor, Sensel firmware, touchpad power repair, NVIDIA dual-GPU health) referenced by the InputDiagnostics README.docs(reports)— workstation-audit-20260606 (incl. SUMMARY.md, NVIDIA Code 31 finding) + power-maintenance-20260606 bundles.Notes
🤖 Generated with Claude Code