Skip to content

Add cacheConfig, setter process, getter script#743

Open
bsofjan wants to merge 1 commit into
DataIntellectTech:masterfrom
bsofjan:configsettergetter
Open

Add cacheConfig, setter process, getter script#743
bsofjan wants to merge 1 commit into
DataIntellectTech:masterfrom
bsofjan:configsettergetter

Conversation

@bsofjan
Copy link
Copy Markdown

@bsofjan bsofjan commented May 29, 2026

Add cacheConfig, setter process, getter script

@CJA18
Copy link
Copy Markdown

CJA18 commented Jun 2, 2026

A few general things you need to do when committing to TorQ:

  • The PR needs a more detailed description outlining the reason for it, what's being achieved, future steps to come etc
  • A lot of these functions seem to be something common that has likely been done already and might have an existing util function, always check for this first as it's best practice to reuse the existing utils (if something needs to be changed then it only needs to be changed in one place)
  • Follow coding standards, if you look at the rest of the codebase camelCase isn't used so follow whatever standard is used in the codebase
  • For comments, in the rest of the codebase you'll see that the comments are generally block comments for each function describing what the function and each step in the function is doing, and inline comments are used in special cases (check the codebase to see when to use them)
  • You committed an empty json config file, it's better to commit a file with some defaults so a reviewer can get an idea of what it will be used for

Comment thread code/common/getter.q
@@ -0,0 +1,3 @@
\d .getter

getCacheFromDisk:{[filePath] load hsym filePath} No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

escape the getter namespace at the end of this file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants