Skip to content

fix: include -f option on curl download#26

Merged
daniel-mohedano merged 1 commit into
mainfrom
daniel.mohedano/failure-handling
May 21, 2026
Merged

fix: include -f option on curl download#26
daniel-mohedano merged 1 commit into
mainfrom
daniel.mohedano/failure-handling

Conversation

@daniel-mohedano

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Add -f option on curl downloads to surface request errors (instead of failing during sha256 check with the errored HTML document).

Motivation

Additional Notes

Now the request failures bubble up instead of being swallowed:

DD_CIVISIBILITY_ENABLED=true
DD_CIVISIBILITY_AGENTLESS_ENABLED=true
DD_ENV=ci
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404

While previously the error would look like:

DD_CIVISIBILITY_ENABLED=true
DD_CIVISIBILITY_AGENTLESS_ENABLED=true
DD_ENV=ci
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100     9    0     9    0     0  10368      0 --:--:-- --:--:-- --:--:--  9000
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100     9    0     9    0     0  11042      0 --:--:-- --:--:-- --:--:--  9000
sha256sum: 'standard input': no properly formatted checksum lines found

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@daniel-mohedano
daniel-mohedano requested a review from a team as a code owner May 21, 2026 14:33
@daniel-mohedano
daniel-mohedano merged commit 8627f29 into main May 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants