Replace http data source with aws_s3_object for forwarder versions#52
Draft
cahillsf wants to merge 1 commit into
Draft
Replace http data source with aws_s3_object for forwarder versions#52cahillsf wants to merge 1 commit into
cahillsf wants to merge 1 commit into
Conversation
Avoids requiring the separate hashicorp/http provider and unmocked network calls in tests by fetching versions.json via the aws provider already used elsewhere in the module. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data "http" "forwarder_versions"withdata "aws_s3_object" "forwarder_versions", dropping the dependency on the separatehashicorp/httpprovider since the bucket is fetched via the already-requiredawsprovider.tftest.hclfiles to mockaws_s3_object(global defaults or per-run overrides) instead of relying on live network calls to the public S3 bucket during tests.Test plan
terraform validatepassesterraform test— 54/54 passing in the root module