Skip to content

[AWSX] feat(logs forwarder): Remove StepFunctions tag enrichment from logs forwarder#30

Merged
ndakkoune merged 2 commits into
mainfrom
georgi/remove-stepfunctions-tags
Jul 23, 2026
Merged

[AWSX] feat(logs forwarder): Remove StepFunctions tag enrichment from logs forwarder#30
ndakkoune merged 2 commits into
mainfrom
georgi/remove-stepfunctions-tags

Conversation

@ge0Aja

@ge0Aja ge0Aja commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

@ge0Aja
ge0Aja requested review from a team as code owners February 4, 2026 12:34
@ViBiOh ViBiOh self-assigned this Feb 9, 2026
@ndakkoune
ndakkoune requested a review from a team as a code owner July 7, 2026 16:25
@gh-worker-ownership-write-b05516
gh-worker-ownership-write-b05516 Bot removed request for a team July 7, 2026 16:25
@ndakkoune
ndakkoune merged commit 98d4b64 into main Jul 23, 2026
4 checks passed
@ndakkoune
ndakkoune deleted the georgi/remove-stepfunctions-tags branch July 23, 2026 08:30
@Jno21

Jno21 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

I don't think removing a variable should count as a feat. this should have been a breaking change. It broke our integration because we use the constraint ~> 1.3 to pull in feature updates automatically, so the removal came through as a minor bump instead of a major one.

Would it be possible to re-tag this, since we're probably not the only ones affected?

@ndakkoune

Copy link
Copy Markdown

I don't think removing a variable should count as a feat. this should have been a breaking change. It broke our integration because we use the constraint ~> 1.3 to pull in feature updates automatically, so the removal came through as a minor bump instead of a major one.

Would it be possible to re-tag this, since we're probably not the only ones affected?

@Jno21 Hello Jonathan, thank you for noticing. Since we cannot delete already created tags (referenced by our Terraform registry), we did a v2.0.0 release with the breaking changes and a v1.4.4 without these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants