test(ffe): enable Node.js agentless configuration

[leoromanovsky]

Motivation

DataDog/dd-trace-js#9397 adds the Node.js agentless Feature Flagging configuration source and is targeted for v6.5.0 through DataDog/dd-trace-js#9414. The shared configuration-source contract is already on main; Node.js now needs its manifest activation and updated default Remote Configuration capability expectation.

The contract also provides the cross-repository motivation for DataDog/dd-trace-js#9468: local and controlled custom agentless endpoints must be reachable, missing authentication must be observable, and unsupported source values must fail without contacting either delivery surface.

Changes

• Enable tests/parametric/test_ffe/test_configuration_sources.py for Node.js starting with v6.5.0.
• Stop expecting the FFE Remote Configuration capability in the default Node.js capability set from v6.5.0 onward.
• Keep provider startup errors inside the Node.js parametric controller /ffe/start response so negative source tests can assert startup failure and zero CDN or Remote Configuration traffic.

Decisions

• Use an explicit v6.5.0 manifest gate rather than enabling the suite for older Node.js tracer versions.
• Preserve the default capability expectation for >=5.72.0 <6.5.0; from v6.5.0, capability 46 and the FFE_FLAGS product are registered only when Feature Flags explicitly selects remote_config, which the existing configuration-source contract validates.
• Treat unsupported provider-source exceptions as a failed start response rather than allowing the parametric process to terminate before the shared assertions run.

[github-actions]

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/dd-trace-js
tests/parametric/capabilities.yml                                       @DataDog/system-tests-core @DataDog/apm-sdk-capabilities
utils/build/docker/nodejs/parametric/server.js                          @DataDog/dd-trace-js @DataDog/system-tests-core

[datadog-datadog-us1-prod]

 

⚠️ Warnings

🚦 3 Pipeline jobs failed

Testing the test | System Tests (nodejs, dev) / parametric / parametric (2)     

🧪 2 Tests failed

tests.parametric.test_ffe.test_configuration_sources.Test_Feature_Flag_Configuration_Source_Selection.test_invalid_configuration_source_fails_closed[library_env0, parametric-nodejs] from system_tests_suite  

AssertionError: unexpected mock FFE agentless backend request: status={'requests_total': 1, 'in_flight': 0, 'max_in_flight': 1, 'last_path': '/api/v2/feature-flagging/config/rules-based/server', 'last_if_none_match': None, 'last_auth_present': False, 'last_status_code': 200, 'status_codes': [200]}
assert 1 == 0

self = <tests.parametric.test_ffe.test_configuration_sources.Test_Feature_Flag_Configuration_Source_Selection object at 0x7f16527e8c80>
test_agent = <utils.docker_fixtures._test_agent.TestAgentAPI object at 0x7f1651b323f0>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7f1651d15010>
mock_ffe_agentless_backend = <utils.docker_fixtures._mock_ffe_agentless_backend.MockFFEAgentlessBackendServer object at 0x7f1651b55a90>

    @parametrize("library_env", [{"configuration_source": "invalid", "response": "valid"}], indirect=True)
    def test_invalid_configuration_source_fails_closed(
...

tests.parametric.test_ffe.test_configuration_sources.Test_Feature_Flag_Configuration_Source_Selection.test_reserved_offline_configuration_source_fails_closed[library_env0, parametric-nodejs] from system_tests_suite  

AssertionError: unexpected mock FFE agentless backend request: status={'requests_total': 1, 'in_flight': 0, 'max_in_flight': 1, 'last_path': '/api/v2/feature-flagging/config/rules-based/server', 'last_if_none_match': None, 'last_auth_present': False, 'last_status_code': 200, 'status_codes': [200]}
assert 1 == 0

self = <tests.parametric.test_ffe.test_configuration_sources.Test_Feature_Flag_Configuration_Source_Selection object at 0x7f16527e8f80>
test_agent = <utils.docker_fixtures._test_agent.TestAgentAPI object at 0x7f1651b323f0>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7f1651736000>
mock_ffe_agentless_backend = <utils.docker_fixtures._mock_ffe_agentless_backend.MockFFEAgentlessBackendServer object at 0x7f1651b54890>

    @parametrize("library_env", [{"configuration_source": "offline", "response": "valid"}], indirect=True)
    def test_reserved_offline_configuration_source_fails_closed(
...

Testing the test | System Tests (nodejs, prod) / parametric / parametric (1)     

🧪 16 Tests failed

tests.parametric.test_dynamic_configuration.TestDynamicConfigTracingEnabled.test_default_capability_completeness[library_env0, parametric-nodejs] from system_tests_suite  

AssertionError: seen_but_not_expected_capabilities={<Capabilities.FFE_FLAG_CONFIGURATION_RULES: 46>}; Update capabilities.yml to fix this.

self = <tests.parametric.test_dynamic_configuration.TestDynamicConfigTracingEnabled object at 0x7f20686e98b0>
test_agent = <utils.docker_fixtures._test_agent.TestAgentAPI object at 0x7f203542a270>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7f203557c6b0>

    @parametrize("library_env", [{**DEFAULT_ENVVARS}])
    def test_default_capability_completeness(self, test_agent: TestAgentAPI, test_library: APMLibrary) -> None:
        """Ensure the RC request contains the expected default capabilities per language.
    
...

tests.parametric.test_ffe.test_configuration_sources.Test_Feature_Flag_Configuration_Source_Cold_Failure_And_Recovery.test_bad_to_good_cold_recovery[server-error-to-valid, parametric-nodejs] from system_tests_suite  

AssertionError: failed to start FFE provider for bad_to_good
assert False
 +  where False = <bound method ParametricTestClientApi.ffe_start of <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7fc54967ef30>>()
 +    where <bound method ParametricTestClientApi.ffe_start of <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7fc54967ef30>> = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7fc54967ef30>.ffe_start

self = <tests.parametric.test_ffe.test_configuration_sources.Test_Feature_Flag_Configuration_Source_Cold_Failure_And_Recovery object at 0x7fc5791b89b0>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7fc54967ef30>
mock_ffe_agentless_backend = <utils.docker_fixtures._mock_ffe_agentless_backend.MockFFEAgentlessBackendServer object at 0x7fc549079880>
expected_status_codes = [500, 200]

...

View all failed tests

Testing the test | all-jobs-are-green     

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e7d60b1 | Docs | Datadog PR Page | Give us feedback!}