feat(dev): add Windows cross-build support#1790
Conversation
This comment has been minimized.
This comment has been minimized.
Binary Size Analysis (Agent Data Plane)Baseline: 08cd4c4 · Comparison: 4aa3ff2 · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (35)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
| (echo "Missing llvm-lib at $(WINDOWS_CROSS_LLVM_BIN)/llvm-lib. Set WINDOWS_CROSS_LLVM_BIN or install Homebrew LLVM." && exit 1) | ||
|
|
||
| .PHONY: build-windows-cross | ||
| build-windows-cross: install-windows-cross-tools ## Builds ADP for Windows from a local macOS host (override WINDOWS_CROSS_CARGO_ARGS as needed) |
There was a problem hiding this comment.
Adding this for now as a way to locally test Windows support. May remove this once we have Windows CI working
| System::Registry::{RegGetValueW, HKEY, HKEY_LOCAL_MACHINE, RRF_RT_REG_SZ, RRF_SUBKEY_WOW6464KEY}, | ||
| }; | ||
|
|
||
| // TODO: Add Windows-specific tests for registry-backed path resolution once we have Windows CI coverage. |
There was a problem hiding this comment.
This file is vibed from the core agent impl but untested as we don't actually have tests running yet. Added a TODO to come back and add tests.
pls look toby
With this PR it's now possible to cross-compile ADP-for-Windows on a Mac. Nothing is actually runnable but I wanted to get this sorted before I started working on Windows CI.
I scoped this to only saluki and agent-data-plane, testing tools like
correctnessare not in scope and probably still don't build on Windows. I'm not planning on runningcorrectnessbut if any of those have problems I'll get to them as part of the CI PR.Summary
cargo-xwinand Homebrew LLVM.x86_64-pc-windows-msvc.Notes
Test plan
make fmtcargo check --workspacecargo check --workspace --testsmake build-windows-crossPATH="/opt/homebrew/opt/llvm/bin:$PATH" cargo xwin check --target x86_64-pc-windows-msvc --workspace --testsgit commit