enhancement(dev): add skill for triggering CI on external contributions#1723
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25d9e70e2e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Binary Size Analysis (Agent Data Plane)Baseline: f907c91 · Comparison: 1efca47 · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (35)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
This comment has been minimized.
This comment has been minimized.
…ns (#1723) ## Summary As stated in the PR title. PRs from external contributors (as in forks) do not trigger CI: only branches pushed directly to the repository (and thus, implied by that, authorized contributors) can trigger CI. In order to make it possible to accept external contributions and, in doing so, verify that they pass CI, we need a way to repeatably trigger CI. This PR adds a new Claude skill that automates the manual steps of doing so with a command invocation that's as simple as: `/external-pr-ci-trigger <PR number>` This skill uses the `gh` CLI, and normal Git commands, to pull down the remote fork/branch and repush them to the main repository with a specific branch naming scheme. The push alone triggers CI, but the branch name matching a specific format will allow the CI pipeline to be automatically associated with the external contributor's PR, so that all check status is propagated just as if it was triggered directly. ## Change Type - [ ] Bug fix - [x] New feature - [ ] Non-functional (chore, refactoring, docs) - [ ] Performance ## How did you test this PR? Ran the skill locally on #1671 and observed that it created the branch _and_ triggered CI properly, with the PR showing the checks running. ## References DADP-2 Co-authored-by: toby.lawrence <toby.lawrence@datadoghq.com> 09880b1
Summary
As stated in the PR title.
PRs from external contributors (as in forks) do not trigger CI: only branches pushed directly to the repository (and thus, implied by that, authorized contributors) can trigger CI.
In order to make it possible to accept external contributions and, in doing so, verify that they pass CI, we need a way to repeatably trigger CI. This PR adds a new Claude skill that automates the manual steps of doing so with a command invocation that's as simple as:
/external-pr-ci-trigger <PR number>This skill uses the
ghCLI, and normal Git commands, to pull down the remote fork/branch and repush them to the main repository with a specific branch naming scheme. The push alone triggers CI, but the branch name matching a specific format will allow the CI pipeline to be automatically associated with the external contributor's PR, so that all check status is propagated just as if it was triggered directly.Change Type
How did you test this PR?
Ran the skill locally on #1671 and observed that it created the branch and triggered CI properly, with the PR showing the checks running.
References
DADP-2