Split TCP RR infrastructure from the workload#1905
Conversation
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1785a95bb9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| /// Flow count is *not* configured here — it is owned by the | ||
| /// `tcp_rr` blackhole and communicated to the generator over the control port | ||
| /// during startup. |
There was a problem hiding this comment.
When an existing tcp_rr generator config contains the previously documented flows field, this new schema rejects it because Config still uses deny_unknown_fields; moving the field solely to the blackhole means those user configs fail at startup rather than running, despite /workspace/lading/AGENTS.md stating that user configs need stability. Please keep accepting the generator-side field during a migration or otherwise translate it instead of making existing experiment configs invalid.
Useful? React with 👍 / 👎.
|
|
||
| /// Control-channel handshake: server writes `flows` to the accepted control | ||
| /// connection as a 2-byte big-endian `u16` and closes; client reads the same | ||
| /// 2 bytes after connecting. Internal protocol — no magic / version byte. |
There was a problem hiding this comment.
This newly added doc comment contains a non-ASCII em dash, and /workspace/lading/AGENTS.md requires US-ASCII only in code and documentation. There are multiple new occurrences in this file, so replace these punctuation characters with ASCII equivalents before landing.
Useful? React with 👍 / 👎.
1 participant
What does this PR do?
This PR refactors the tcp_rr workload to split the infrastructure elements into a separate file. This will allow subsequent workloads to reuse the same thread and flow management code.
Motivation
Related issues
Additional Notes