Skip to content

Avoid inherited tag signing in release script#63

Merged
juan-fernandez merged 1 commit into
mainfrom
juan-fernandez/no-sign-release-tags
Jul 1, 2026
Merged

Avoid inherited tag signing in release script#63
juan-fernandez merged 1 commit into
mainfrom
juan-fernandez/no-sign-release-tags

Conversation

@juan-fernandez

Copy link
Copy Markdown
Contributor

Summary

  • Add --no-sign to the release script's immutable and moving-major git tag commands.

Why

The release script creates lightweight action tags and then pushes them to GitHub. If a developer has tag.gpgsign=true in their Git config, plain git tag <tag> <sha> is interpreted as a signed annotated tag creation instead of the lightweight tag the script expects.

That changes the command contract and can fail with fatal: no tag message? because the script does not provide an annotated tag message. Passing --no-sign makes the script's existing lightweight-tag behavior explicit and keeps global Git config from changing release behavior.

This also applies to the moving major tag, since v3 is intentionally force-updated and should follow the same explicit tag creation semantics as before.

Validation

  • bash -n scripts/release-action.sh
  • git verify-commit HEAD

@juan-fernandez juan-fernandez added the semver-patch Requests a patch action release after merge label Jul 1, 2026
@juan-fernandez juan-fernandez marked this pull request as ready for review July 1, 2026 14:28
@juan-fernandez juan-fernandez requested review from a team as code owners July 1, 2026 14:28
@datadog-official

datadog-official Bot commented Jul 1, 2026

Copy link
Copy Markdown

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

Test Action | test-default-datadog-ci-version   View in Datadog   GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3ce56a9 | Docs | Datadog PR Page | Give us feedback!

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The PR correctly adds --no-sign to both tag creation commands (lines 297–298), ensuring lightweight tags are created regardless of global tag.gpgsign configuration. Validated that: (1) the flag syntax is correct and overrides gpgsign config, (2) force-update behavior is preserved with -f, and (3) script syntax passes bash -n validation. No behavioral regressions detected.

Was this helpful? React 👍 or 👎

📊 Validated against 4 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 3ce56a9 · What is Autotest? · Any feedback? Reach out in #autotest

@juan-fernandez juan-fernandez added semver-minor Requests a minor junit-upload-github-action release after merge and removed semver-minor Requests a minor junit-upload-github-action release after merge labels Jul 1, 2026
@juan-fernandez juan-fernandez merged commit cd33607 into main Jul 1, 2026
25 of 28 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/no-sign-release-tags branch July 1, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch Requests a patch action release after merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants