Skip to content

[APPSEC-61865] Change expected payload keys to normalized format#5799

Merged
Strech merged 1 commit into
masterfrom
appsec-61865-adjust-response-event-keys
May 21, 2026
Merged

[APPSEC-61865] Change expected payload keys to normalized format#5799
Strech merged 1 commit into
masterfrom
appsec-61865-adjust-response-event-keys

Conversation

@Strech
Copy link
Copy Markdown
Member

@Strech Strech commented May 21, 2026

What does this PR do?

Update camel case keys to snake case for upcoming normalization fix

Motivation:

This was overlooked and as it's not used now, I decided to fix it properly on both sides Lambda and AppSec

Change log entry

None.

Additional Notes:

Fixed in Lambda too DataDog/datadog-lambda-rb#144

How to test the change?

CI

@Strech Strech requested a review from a team as a code owner May 21, 2026 08:18
@dd-octo-sts dd-octo-sts Bot added integrations Involves tracing integrations appsec Application Security monitoring product labels May 21, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: abbf377e5f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/datadog/appsec/contrib/aws_lambda/waf_addresses.rb
Copy link
Copy Markdown
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Might be good to link to the other PRs that change this on the lambda/etc side so we could match them up :)

@datadog-datadog-prod-us1
Copy link
Copy Markdown
Contributor

datadog-datadog-prod-us1 Bot commented May 21, 2026

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 0.00%
Overall Coverage: 97.08% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 66cf7a3 | Docs | Datadog PR Page | Give us feedback!

@Strech Strech force-pushed the appsec-61865-adjust-response-event-keys branch from abbf377 to 66cf7a3 Compare May 21, 2026 11:32
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 21, 2026

Benchmarks

Benchmark execution time: 2026-05-21 11:58:02

Comparing candidate commit 66cf7a3 in PR branch appsec-61865-adjust-response-event-keys with baseline commit a81fd15 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@Strech Strech merged commit a5d8360 into master May 21, 2026
585 checks passed
@Strech Strech deleted the appsec-61865-adjust-response-event-keys branch May 21, 2026 13:03
@Strech Strech changed the title Change expected payload keys to normalized format [APPSEC-61865] Change expected payload keys to normalized format May 21, 2026
@dd-octo-sts dd-octo-sts Bot added this to the 2.34.0 milestone May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appsec Application Security monitoring product integrations Involves tracing integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants