You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This does not yet trigger in CI and that is because we do not run profiler tests against ZTS ASAN because the ZTS ASAN images we prebuild only have DEBUG ZTS ASAN and no NDEBUG version, but the profiler does not build against DEBUG PHP builds.
I hacked this a bit locally and not only does this newly added test fail, but also the other preloading test:
Number of tests : 40
Tests skipped : 11
Tests failed : 2
Tests passed : 27
Failed tests:
[profiling] Profiling should only be enabled after preloading has happened
[profiling] ASAN regression: ZTS preloading must not duplicate INI values from themselves
ASAN caught the expected issue:
ERROR: AddressSanitizer: heap-use-after-free
READ of size 4
#0 zend_string_dup .../Zend/zend_string.h:217
#1 zai_config_ini_rinit .../zend_abstract_interface/config/config_ini.c:429
...
freed by thread T0 here:
#1 zend_string_release .../Zend/zend_string.h:339
#2 zai_config_ini_rinit .../zend_abstract_interface/config/config_ini.c:428
🔄 Retry job. This looks flaky and may succeed on retry.
Failed to write archive entry contents due to ConnectionReset: reqwest::Error: source hyper::Error (Io connection reset).
🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration.
Failed to install live debugger span decoration probe. Error: command terminated with exit code 2.
We already have a test that fails, it is just not executed, as we where missing ZTS ASAN tests, but #3908 adds these
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a test for #3898 / #3896
This does not yet trigger in CI and that is because we do not run profiler tests against ZTS ASAN because the ZTS ASAN images we prebuild only have DEBUG ZTS ASAN and no NDEBUG version, but the profiler does not build against DEBUG PHP builds.
I hacked this a bit locally and not only does this newly added test fail, but also the other preloading test: