libdatadog update to 3bf778c3#3895
Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e412997b4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit cea1e44edddd9124f75d5095f31026904a1f58d8 | |||
| Subproject commit 0f83957630ee6eb945f70f3036f0e937a862f99a | |||
There was a problem hiding this comment.
Revert submodule bump to failing libdatadog revision
This change advances libdatadog to 0f839576, but the commit metadata for this exact update reports a full CI failure (64 failed jobs in pipeline 114403599), which indicates the pinned revision is not currently integration-safe for dd-trace-php. Merging this pointer as-is will keep the main branch on a known-bad dependency state across the tested matrix; keep the previous SHA until the upstream breakage is fixed or a known-good follow-up SHA is identified.
Useful? React with 👍 / 👎.
56080c7 to
2f06e0d
Compare
be710ed to
fb95ca7
Compare
Automated update by CI pipeline https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/115068209 Full CI result: ❌ 51 job(s) failed
fb95ca7 to
d3b1ff4
Compare
Summary
Automated update of the libdatadog submodule to the latest HEAD.
cea1e44edddd9124f75d5095f31026904a1f58d83bf778c328d4d250d8fc8bf166a8c490bc55a59dFull CI result: ❌ 51 job(s) failed
CI pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/115068209
libdatadog Integration Report
libdatadog SHA: 3bf778c328d4d250d8fc8bf166a8c490bc55a59d
Analysis date: 2026-05-25
Overall status
❌ Blocking issues remain — but the blocker is a CI infrastructure problem, not a libdatadog API issue. Compilation never started, so libdatadog API compatibility is undetermined.
Build & test summary
All 51 reported failures are jobs that compile Rust against libdatadog:
compile extension: debug[-zts-asan]: [<php>, <arch>](tracer-trigger)compile tracing extension asan: [<php>, <arch>, <target>](package-trigger)aggregate tested versions(tracer-trigger) — downstream failure dependent on the above.Every one of the 50 trace files in
tmp/artifacts/traces/shows the same error in theinjected libdatadog override step, before any cargo/make invocation:
Consequences:
matrix it depends on failed.
Non-trivial changes made
No code changes required.
Per the task constraints I do not edit anything under
libdatadog/, and the dd-trace-phpRust source could not be evaluated because compilation never ran. The remaining failure
class is a CI shim problem (the override step prepended by
.gitlab/generate-common.php:117runs before anygit config --global --add safe.directoryis applied for the submodule path), which is outside the libdatadog-API-adaptation scope of
this task.
For follow-up by the CI team: the injected step at
.gitlab/generate-common.php:116-119needs to either run in a context where the libdatadog submodule directory is already
marked safe, or be prepended with:
- git config --global --add safe.directory "${CI_PROJECT_DIR}/libdatadog"The pattern is already established for the main repo and other submodules — e.g.
.gitlab/libdatadog-latest.yml:16-17,.gitlab/generate-tracer.php:43-44,.gitlab/generate-appsec.php:55— but the override-SHA injection path bypasses thosebecause it prepends to
before_scriptahead of the normal preamble.Identified libdatadog issues
None identified.
The new libdatadog SHA contains the following commits since the pinned SHA (from
tmp/artifacts/libdatadog_changelog.txt):Two of these are flagged breaking (
feat(trace-utils)!: add from_string to span textandfeat!: add encoder from v04 to v1) and may well require dd-trace-php adaptation onceCI can actually build. They cannot be evaluated from this pipeline. Re-run after the CI
shim issue above is resolved.
Flaky / ignored failures
None. Every persistent failure in this pipeline is the same deterministic git
"dubious ownership" error in the override-SHA injection step.
/cc @bwoebi