Skip to content

libdatadog update to 3bf778c3#3895

Open
dd-octo-sts[bot] wants to merge 1 commit into
masterfrom
bot/libdatadog-latest
Open

libdatadog update to 3bf778c3#3895
dd-octo-sts[bot] wants to merge 1 commit into
masterfrom
bot/libdatadog-latest

Conversation

@dd-octo-sts
Copy link
Copy Markdown
Contributor

@dd-octo-sts dd-octo-sts Bot commented May 21, 2026

Summary

Automated update of the libdatadog submodule to the latest HEAD.

SHA
Previous cea1e44edddd9124f75d5095f31026904a1f58d8
New 3bf778c328d4d250d8fc8bf166a8c490bc55a59d

Full CI result: ❌ 51 job(s) failed
CI pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/115068209


libdatadog Integration Report

libdatadog SHA: 3bf778c328d4d250d8fc8bf166a8c490bc55a59d
Analysis date: 2026-05-25

Overall status

❌ Blocking issues remain — but the blocker is a CI infrastructure problem, not a libdatadog API issue. Compilation never started, so libdatadog API compatibility is undetermined.

Build & test summary

All 51 reported failures are jobs that compile Rust against libdatadog:

  • 36 × compile extension: debug[-zts-asan]: [<php>, <arch>] (tracer-trigger)
  • 14 × compile tracing extension asan: [<php>, <arch>, <target>] (package-trigger)
  • 1 × aggregate tested versions (tracer-trigger) — downstream failure dependent on the above.

Every one of the 50 trace files in tmp/artifacts/traces/ shows the same error in the
injected libdatadog override step, before any cargo/make invocation:

$ git -C libdatadog fetch --depth=1 origin "3bf778c328d4d250d8fc8bf166a8c490bc55a59d" 2>&1
fatal: detected dubious ownership in repository at
'/go/src/github.com/DataDog/apm-reliability/dd-trace-php/libdatadog'
To add an exception for this directory, call:
	git config --global --add safe.directory /go/src/github.com/DataDog/apm-reliability/dd-trace-php/libdatadog
ERROR: Job failed: command terminated with exit code 128

Consequences:

  • No Rust code from dd-trace-php was compiled against the new libdatadog SHA.
  • We cannot observe API breakage or confirm API compatibility from this pipeline.
  • The "aggregate tested versions" job fails transitively because every compile job in the
    matrix it depends on failed.

Non-trivial changes made

No code changes required.

Per the task constraints I do not edit anything under libdatadog/, and the dd-trace-php
Rust source could not be evaluated because compilation never ran. The remaining failure
class is a CI shim problem (the override step prepended by
.gitlab/generate-common.php:117 runs before any git config --global --add safe.directory
is applied for the submodule path), which is outside the libdatadog-API-adaptation scope of
this task.

For follow-up by the CI team: the injected step at .gitlab/generate-common.php:116-119
needs to either run in a context where the libdatadog submodule directory is already
marked safe, or be prepended with:

- git config --global --add safe.directory "${CI_PROJECT_DIR}/libdatadog"

The pattern is already established for the main repo and other submodules — e.g.
.gitlab/libdatadog-latest.yml:16-17, .gitlab/generate-tracer.php:43-44,
.gitlab/generate-appsec.php:55 — but the override-SHA injection path bypasses those
because it prepends to before_script ahead of the normal preamble.

Identified libdatadog issues

None identified.

The new libdatadog SHA contains the following commits since the pinned SHA (from
tmp/artifacts/libdatadog_changelog.txt):

3bf778c32 chore: set gitlab reference back to main branch (#2035)
362f511c1 chore(release): merge release branch to main (proposal for libdd-data-pipeline (#2028)) (#2034)
276039da8 ci: bump msrv to 1.87.0 (#2017)
118d26070 fix(crashtracker): move preload logger marking after recursive guard (#2023)
dbc2cf75e chore(dependencies): only depend on the windows crate when targeting windows (#2024)
09d307ddc ci: use builder on windows platforms (#1961)
76474462f chore(sidecar): reorg/remove unsafe code in span FFI (#1698)
321ffb69a refactor(otel-thread-ctx): doc and style fixes for ThreadContextRecord (#2019)
0f8395763 refactor(otel-thread-ctx): add const offset assertions for ThreadContextRecord (#2018)
d96d16049 refactor(otel-thread-ctx): backport review suggestions from Polar Signals (#2016)
ecdca7d4e feat(trace-utils)!: add from_string to span text (#2011)
3cc5a96ee chore: release v34.0.0 (#2015)
e2fb8860d feat!: add encoder from v04 to v1 (#1896)

Two of these are flagged breaking (feat(trace-utils)!: add from_string to span text and
feat!: add encoder from v04 to v1) and may well require dd-trace-php adaptation once
CI can actually build. They cannot be evaluated from this pipeline. Re-run after the CI
shim issue above is resolved.

Flaky / ignored failures

None. Every persistent failure in this pipeline is the same deterministic git
"dubious ownership" error in the override-SHA injection step.


/cc @bwoebi

@dd-octo-sts dd-octo-sts Bot requested a review from a team as a code owner May 21, 2026 02:26
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented May 21, 2026

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 13 Pipeline jobs failed

Profiling correctness | prof-correctness (8.0, nts)   View in Datadog   GitHub Actions

🔧 Fix in code (Fix with Cursor). Compilation error: use of unstable library feature `unsigned_is_multiple_of` in libdatadog/libdd-profiling/src/internal/profile/interning_api/mod.rs:237:20

Profiling correctness | prof-correctness (8.0, zts)   View in Datadog   GitHub Actions

🔧 Fix in code (Fix with Cursor). Use of unstable library feature 'unsigned_is_multiple_of' in mod.rs:237

Profiling correctness | prof-correctness (8.1, nts)   View in Datadog   GitHub Actions

🔧 Fix in code (Fix with Cursor). Use of unstable library feature 'unsigned_is_multiple_of' in mod.rs:237

View all 13 failed jobs.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d3b1ff4 | Docs | Datadog PR Page | Give us feedback!

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e412997b4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread libdatadog Outdated
@@ -1 +1 @@
Subproject commit cea1e44edddd9124f75d5095f31026904a1f58d8
Subproject commit 0f83957630ee6eb945f70f3036f0e937a862f99a
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Revert submodule bump to failing libdatadog revision

This change advances libdatadog to 0f839576, but the commit metadata for this exact update reports a full CI failure (64 failed jobs in pipeline 114403599), which indicates the pinned revision is not currently integration-safe for dd-trace-php. Merging this pointer as-is will keep the main branch on a known-bad dependency state across the tested matrix; keep the previous SHA until the upstream breakage is fixed or a known-good follow-up SHA is identified.

Useful? React with 👍 / 👎.

@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 0f839576 libdatadog update to 09d307dd May 22, 2026
@dd-octo-sts dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch 2 times, most recently from 56080c7 to 2f06e0d Compare May 23, 2026 02:20
@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 09d307dd libdatadog update to 118d2607 May 23, 2026
@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 118d2607 libdatadog update to 276039da May 24, 2026
@dd-octo-sts dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch 2 times, most recently from be710ed to fb95ca7 Compare May 25, 2026 03:18
@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 276039da libdatadog update to 3bf778c3 May 26, 2026
@dd-octo-sts dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from fb95ca7 to d3b1ff4 Compare May 26, 2026 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants