feat(dbm): add dynamic_service propagation mode#8592
Conversation
amarziali
requested review from
crysmags and
raphaelgavache
and removed request for
a team
Overall package sizeSelf size: 5.87 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 4dfb204 | Docs | Datadog PR Page | Give us feedback! |
BenchmarksBenchmark execution time: 2026-05-26 10:30:57 Comparing candidate commit 4dfb204 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1491 metrics, 102 unstable metrics. |
| * Programmatic configuration takes precedence over the environment variables listed above. | ||
| */ | ||
| dbmPropagationMode?: 'disabled' | 'service' | 'full' | ||
| dbmPropagationMode?: 'disabled' | 'service' | 'full' | 'dynamic_service' |
There was a problem hiding this comment.
Would you mind adding a description for the functionality here in the documentation? It would otherwise be difficult to understand how to use what mode as user.
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
Adding the shorthand is probably fine, while I personally mostly rather have a single option that does something.
Is it intended to remove the DD_DBM_INJECT_SQL_BASEHASH env at some point?
That aside: if we do this, please add an allowed entry to DD_DBM_PROPAGATION_MODE to validate the input for the users appropriately.
Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
andrea.marziali@datadoghq.com cancelled this merge request build |
|
/merge -c |
|
View all feedbacks in Devflow UI.
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Tests failed on this commit b156466:
What to do next?
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Tests failed on this commit 05ff975:
What to do next?
|
* feat(dbm): add dynamic_service propagation mode * Add doc * add allowed section * Update packages/dd-trace/src/config/supported-configurations.json Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de> * rerun generate config --------- Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
3 participants
What does this PR do?
Introduces a new value for
DD_DBM_PROPAGATION_MODE:dynamic_service.Setting
DD_DBM_PROPAGATION_MODE=dynamic_serviceis a convenience shorthand that combines the behavior of two separate settings:DD_DBM_PROPAGATION_MODE=service— injects a DBM SQL comment with service-level tags (dddb,dddbs,dde,ddh,ddps,ddpv)DD_DBM_INJECT_SQL_BASEHASH=true— additionally injects the propagation hash (ddsh) when process tags are enabledWith
dynamic_service, users get hash injection automatically without needing to setDD_DBM_INJECT_SQL_BASEHASH=truealongside the propagation mode.Motivation
Additional Notes
System tests are provided in this PR: DataDog/system-tests#6997