Fix IAST JDBC instrumentation when getMetadata throws non-SQLException

[smola]

What Does This Do

• Make JDBCDecorator handle non-SQLException exception from connection.getMetadata(), and handle it like any other exception.

Motivation

• We see this method throwing internal exceptions in IAST (seen via telemetry, no app impact), because the connection pool implementation intentionally throws errors that do not extend from SQLException.

Additional Notes

• Database monitoring was not affected, as it had an outer catch for Throwable.
• For IAST, there was no impact to application behavior (there's a catch-all for exceptions in IAST), but this inhibited IAST sinks for beforePrepare.

Contributor Checklist

• Format the title according to the contribution guidelines
• Assign the type: and (comp: or inst:) labels in addition to any other useful labels
• Avoid using close, fix, or any linking keywords when referencing an issue
  Use solves instead, and assign the PR milestone to the issue
• Update the CODEOWNERS file on source file addition, migration, or deletion
• Update public documentation with any new configuration flags or behaviors

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

[datadog-datadog-prod-us1]

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 7 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-java | Ubuntu_20_amd64.SI94: [test-app-java-alpine]     

🔧 Fix in code (Fix with Cursor).

AssertionError: _container_tags_validator failed to validate trace_id: 44736803481784963 in tests/auto_inject/utils.py:21

DataDog/apm-reliability/dd-trace-java | Ubuntu_20_amd64.SI94: [test-app-java-container]     

🔧 Fix in code (Fix with Cursor).

AssertionError: _container_tags_validator failed to validate trace_id: 92340049443385284 in tests/auto_inject/utils.py:79 while running test_origin_detection.

DataDog/apm-reliability/dd-trace-java | Ubuntu_23_10_arm64.SI94: [test-app-java-alpine]     

🔧 Fix in code (Fix with Cursor).

AssertionError: _container_tags_validator failed to validate trace_id: 30713731604332072 in tests/auto_inject/utils.py at line 79.

View all 7 failed jobs.

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6a51445 | Docs | Datadog PR Page | Give us feedback!}

[jandro996]

LGTM! Thanks for catch this :)

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6a51445772

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Move the new JDBC coverage to JUnit 5

The repository guidance in /workspace/dd-trace-java/AGENTS.md says test changes must use JUnit 5 and explicitly says not to write new Groovy/Spock tests, migrating existing Groovy tests instead. This adds a new Spock feature method in IastJDBCTest.groovy, so the change violates the local test-framework rule even though it covers the intended scenario; please add this coverage in JUnit 5 rather than extending the Groovy spec.

Useful? React with 👍 / 👎.

[smola]

Not migrating a full test class in the same PR.