feat(appsec): report agentic onboarding marker in configuration telemetry (RFC-1113)#5055
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoJul 22, 2026
Conversation
…etry (RFC-1113) Register DD_APPSEC_AGENTIC_ONBOARDING as an ordinary string configuration key whose raw value is reported verbatim in the app-started configuration telemetry via stableconfig.String. It is always emitted: unset reports an empty value with origin=default. No derived boolean and no read of AppSec's runtime-enabled state. Ports DataDog/dd-trace-dotnet#8920. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Config Audit |
Contributor
There was a problem hiding this comment.
Pull request overview
Registers DD_APPSEC_AGENTIC_ONBOARDING as a supported configuration key and reports it as configuration telemetry (RFC-1113), always emitting a value (empty string with origin=default when unset).
Changes:
- Added
DD_APPSEC_AGENTIC_ONBOARDINGto the supported configuration keys list (JSON + generated Go map). - Registered the key via
stableconfig.Stringin AppSec config init to emit configuration telemetry unconditionally. - Added unit test coverage to validate telemetry emission and origin/value behavior for set vs unset.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/env/supported_configurations.json | Declares the new config key as a supported string configuration with default empty value. |
| internal/env/supported_configurations.gen.go | Updates the generated supported-configurations map to include the new key. |
| internal/appsec/config/config.go | Registers the new key for app configuration telemetry via stableconfig.String during package init. |
| internal/appsec/config/config_test.go | Verifies telemetry is always emitted and that origin/value match set vs unset cases. |
Files not reviewed (1)
- internal/env/supported_configurations.gen.go: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: bcf3746 | Docs | Datadog PR Page | Give us feedback! |
BenchmarksBenchmark execution time: 2026-07-22 08:21:43 Comparing candidate commit bcf3746 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 325 metrics, 0 unstable metrics, 1 flaky benchmarks without significant changes.
|
e-n-0
approved these changes
Jul 22, 2026
e-n-0
left a comment
e-n-0
left a comment
Member
There was a problem hiding this comment.
LGTM, be sure that the RFC 1113 system tests are correctly passing using this PR
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
christophe-papazian/appsec-agentic-onboarding
branch
July 22, 2026 10:12
This was referenced Jul 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APPSEC-69229
Register
DD_APPSEC_AGENTIC_ONBOARDINGas an ordinary string configuration key, reported verbatim in theapp-startedconfiguration telemetry (RFC-1113). Always emitted: unset reports an empty value withorigin=default. No derived boolean and no read of AppSec's runtime-enabled state.Ports DataDog/dd-trace-dotnet#8920.
🤖 Generated with Claude Code