feat(tracer): Implement OTLP Traces Export #4600
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| // Unless explicitly stated otherwise all files in this repository are licensed | ||
| // under the Apache License Version 2.0. | ||
| // This product includes software developed at Datadog (https://www.datadoghq.com/). | ||
| // Copyright 2016 Datadog, Inc. | ||
|
|
||
| package tracer | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "fmt" | ||
| "io" | ||
| "net/http" | ||
| ) | ||
|
|
||
| // otlpTransport sends protobuf-encoded OTLP payloads over HTTP. | ||
| // It is the OTLP counterpart to httpTransport (which handles Datadog-protocol traffic). | ||
| type otlpTransport struct { | ||
| client *http.Client | ||
| endpoint string | ||
| customHeaders map[string]string | ||
| } | ||
|
|
||
| func newOTLPTransport(client *http.Client, endpoint string, customHeaders map[string]string) *otlpTransport { | ||
| return &otlpTransport{ | ||
| client: client, | ||
| endpoint: endpoint, | ||
| customHeaders: customHeaders, | ||
| } | ||
| } | ||
|
|
||
| // send posts a protobuf-encoded payload to the configured OTLP endpoint. | ||
| func (t *otlpTransport) send(data []byte) error { | ||
|
kakkoyun marked this conversation as resolved.
|
||
| req, err := http.NewRequest("POST", t.endpoint, bytes.NewReader(data)) | ||
|
Member
There was a problem hiding this comment. Should we use a context to be able to cancel the request in case there are timeouts?
Contributor
Author
There was a problem hiding this comment. I'm not sure. We do have a client-set timeout (set when we initialize the client; value comes from tracer's httpClientTimeout config). The agent transport uses the same, context-less approach |
||
| if err != nil { | ||
| return fmt.Errorf("cannot create http request: %w", err) | ||
| } | ||
| req.Header.Set("Content-Type", "application/x-protobuf") | ||
| for header, value := range t.customHeaders { | ||
| req.Header.Set(header, value) | ||
| } | ||
| resp, err := t.client.Do(req) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| defer func() { | ||
| _, _ = io.Copy(io.Discard, resp.Body) | ||
| resp.Body.Close() | ||
| }() | ||
| if code := resp.StatusCode; code >= 400 { | ||
| return fmt.Errorf("HTTP %d: %s", code, http.StatusText(code)) | ||
| } | ||
| return nil | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| // Unless explicitly stated otherwise all files in this repository are licensed | ||
| // under the Apache License Version 2.0. | ||
| // This product includes software developed at Datadog (https://www.datadoghq.com/). | ||
| // Copyright 2016 Datadog, Inc. | ||
|
|
||
| package tracer | ||
|
|
||
| import ( | ||
| "io" | ||
| "net" | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "sync/atomic" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestOTLPTransportSendSuccess(t *testing.T) { | ||
| var received []byte | ||
| srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| received, _ = io.ReadAll(r.Body) | ||
| w.WriteHeader(http.StatusOK) | ||
| })) | ||
| defer srv.Close() | ||
|
|
||
| tr := newOTLPTransport(srv.Client(), srv.URL, nil) | ||
| err := tr.send([]byte("hello")) | ||
| require.NoError(t, err) | ||
| assert.Equal(t, []byte("hello"), received) | ||
| } | ||
|
|
||
| func TestOTLPTransportSendHeaders(t *testing.T) { | ||
| var gotHeaders http.Header | ||
| srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| gotHeaders = r.Header.Clone() | ||
| w.WriteHeader(http.StatusOK) | ||
| })) | ||
| defer srv.Close() | ||
|
|
||
| tr := newOTLPTransport(srv.Client(), srv.URL, map[string]string{ | ||
| "Api-Key": "secret", | ||
| "X-Custom": "value", | ||
| }) | ||
| err := tr.send([]byte("data")) | ||
| require.NoError(t, err) | ||
|
|
||
| assert.Equal(t, "application/x-protobuf", gotHeaders.Get("Content-Type"), "default Content-Type must be set") | ||
| assert.Equal(t, "secret", gotHeaders.Get("Api-Key")) | ||
| assert.Equal(t, "value", gotHeaders.Get("X-Custom")) | ||
| } | ||
|
|
||
| func TestOTLPTransportSendHTTPMethod(t *testing.T) { | ||
| var gotMethod string | ||
| srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| gotMethod = r.Method | ||
| w.WriteHeader(http.StatusOK) | ||
| })) | ||
| defer srv.Close() | ||
|
|
||
| tr := newOTLPTransport(srv.Client(), srv.URL, nil) | ||
| err := tr.send([]byte("data")) | ||
| require.NoError(t, err) | ||
| assert.Equal(t, "POST", gotMethod) | ||
| } | ||
|
|
||
| func TestOTLPTransportSendErrorStatus(t *testing.T) { | ||
| tests := []struct { | ||
| code int | ||
| text string | ||
| }{ | ||
| {http.StatusBadRequest, "Bad Request"}, | ||
| {http.StatusUnauthorized, "Unauthorized"}, | ||
| {http.StatusInternalServerError, "Internal Server Error"}, | ||
| {http.StatusServiceUnavailable, "Service Unavailable"}, | ||
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.text, func(t *testing.T) { | ||
| srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| w.WriteHeader(tt.code) | ||
| })) | ||
| defer srv.Close() | ||
|
|
||
| tr := newOTLPTransport(srv.Client(), srv.URL, nil) | ||
| err := tr.send([]byte("data")) | ||
| require.Error(t, err) | ||
| assert.Contains(t, err.Error(), tt.text) | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestOTLPTransportSendConnectionError(t *testing.T) { | ||
| tr := newOTLPTransport(http.DefaultClient, "http://127.0.0.1:0/nonexistent", nil) | ||
| err := tr.send([]byte("data")) | ||
| require.Error(t, err) | ||
| } | ||
|
|
||
| func TestOTLPTransportConnectionReuse(t *testing.T) { | ||
| var connCount int64 | ||
| srv := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| w.Write([]byte("response body that must be drained")) | ||
| })) | ||
| srv.Config.ConnState = func(_ net.Conn, state http.ConnState) { | ||
| if state == http.StateNew { | ||
| atomic.AddInt64(&connCount, 1) | ||
| } | ||
| } | ||
| srv.Start() | ||
| defer srv.Close() | ||
|
|
||
| tr := newOTLPTransport(srv.Client(), srv.URL, nil) | ||
| for range 5 { | ||
| require.NoError(t, tr.send([]byte("data"))) | ||
| } | ||
| assert.Equal(t, int64(1), atomic.LoadInt64(&connCount), | ||
| "expected a single connection to be reused across sends") | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍