WIP: feat(contrib/go.uber.org/zap): add zap integration#4241
Closed
quinna-h wants to merge 14 commits into
Closed
Conversation
quinna-h
marked this pull request as draft
December 9, 2025 22:08
Codecov Report❌ Patch coverage is Additional details and impacted files
🚀 New features to boost your workflow:
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 282492f | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
quinna-h
marked this pull request as ready for review
December 10, 2025 20:58
kakkoyun
approved these changes
Dec 11, 2025
6 tasks
quinna-h
marked this pull request as draft
January 14, 2026 15:03
This reverts commit 6402c1a.
Contributor
|
superseded by #4729 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Revamp of @rarguelloF PR for v2: contrib/go.uber.org/zap: add basic integration
Makes the following changes:
Limitations:
zapcore.Core.Write()doesn't receive acontext.ContextMotivation
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!