Skip to content

[ignore] Add custom metric tag dropping#1242

Closed
jchrostek-dd wants to merge 1 commit into
mainfrom
dd/custom-metric-tag-drop
Closed

[ignore] Add custom metric tag dropping#1242
jchrostek-dd wants to merge 1 commit into
mainfrom
dd/custom-metric-tag-drop

Conversation

@jchrostek-dd
Copy link
Copy Markdown
Contributor

Please include Jira ticket in title.

Overview

Motivation/Summary

Allow customers to reduce metric tag cardinality by configuring tag keys that should be omitted from custom metrics emitted by the Lambda extension.

Changes

  • Added DD_CUSTOM_METRICS_TAGS_DROP parsing as a comma-separated list of tag keys.
  • Filtered configured tag keys out of the metric aggregator's extension-provided tags.
  • Applied the same filtering to enhanced metric dynamic tags before submission.
  • Added unit coverage for tag-drop matching, tag-provider filtering, env parsing, and enhanced metric dynamic tag filtering.

Testing

  • RUSTUP_TOOLCHAIN=stable cargo fmt --all
  • RUSTUP_TOOLCHAIN=stable cargo fmt --all -- --check
  • git diff --check
  • Attempted RUSTUP_TOOLCHAIN=stable cargo test custom_metrics_tags_drop and RUSTUP_TOOLCHAIN=stable cargo test --locked --offline custom_metrics_tags_drop, but Cargo could not fetch the serverless-components git dependency in this sandbox (403 / offline cache miss).

PR by Bits - View session in Datadog

@datadog-staging
Copy link
Copy Markdown

datadog-staging Bot commented May 29, 2026

View session in Datadog

Bits Dev status: ✅ Done

Copilot AI review requested due to automatic review settings May 29, 2026 21:24
@jchrostek-dd jchrostek-dd requested a review from a team as a code owner May 29, 2026 21:24
@jchrostek-dd jchrostek-dd requested a review from duncanista May 29, 2026 21:24
@jchrostek-dd jchrostek-dd removed request for a team and duncanista May 29, 2026 21:24
@jchrostek-dd jchrostek-dd changed the title Add custom metric tag dropping [ignore] Add custom metric tag dropping May 29, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants