[SVLS-9169] fix: lower log level to DEBUG for a trace failure#1240
Merged
Conversation
lym953
changed the title
…1232) A body-read failure in handle_traces is almost always the tracer connection closing mid-transfer when the Lambda sandbox freezes/terminates at the end of an invocation -- an external lifecycle event, not an extension fault. Logging it at ERROR misleads operators into thinking the extension is broken. This is the same failure class fixed for handle_proxy in #1046 (downgraded to WARN). It is a routine, per-invocation event under load, so it is too noisy even at WARN -- DEBUG keeps it available for diagnosis without alarming operators. Add a debug_response helper alongside the existing error_response/warn_response trio and use it in handle_traces. The message content and HTTP status are unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lym953
force-pushed
the
yiming.luo/fix-1232-handle-traces-body-read
branch
from
0b88b72 to
f7f5f8f
Compare
lym953
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces log noise in the Lambda extension’s trace ingestion path by lowering the log level for a common, non-actionable handle_traces failure when the request body cannot be fully read (often due to the runtime/sandbox freezing and the client disconnecting mid-transfer).
Changes:
- Switch
handle_tracesrequest-body-read failure logging from ERROR to DEBUG. - Introduce a
debug_responsehelper analogous to existingerror_response/warn_responsehelpers.
duncanista
approved these changes
May 28, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Log the
handle_tracesrequest-body-read failure at DEBUG instead of ERROR.Fixes #1232.
Why
This failure happens probably because the execution environment is frozen when tracer sends traces to extension, causing timeout for TCP connections, which is not actionable on extension side. Lowering the log level to reduce noise.
Notes
If any customer sees other issues such as missing traces, let us know and we will treat it as a separate issue.