Skip to content

Add knapsack_pro 9 and 10 appraisals#549

Open
anmarchenko wants to merge 3 commits into
mainfrom
agent/add-knapsack-pro-9-appraisal
Open

Add knapsack_pro 9 and 10 appraisals#549
anmarchenko wants to merge 3 commits into
mainfrom
agent/add-knapsack-pro-9-appraisal

Conversation

@anmarchenko

@anmarchenko anmarchenko commented Jul 24, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Adds knapsack_pro 9 and 10 appraisals for both the RSpec and auto-instrumentation integrations.

RubyGems reports knapsack_pro 9.2.3 and knapsack_pro 10.0.1 as stable, non-yanked releases. The appraisal family now spans knapsack_pro 7 through 10 and includes:

  • knapsack_pro-9-rspec-3
  • knapsack_pro-10-rspec-3
  • generated gemfiles and lockfiles for every supported Ruby runtime
  • matching TEST_METADATA entries for knapsack_rspec and knapsack_auto_instrument

Ruby support

knapsack_pro 9 and 10 require Ruby >= 3.0. Their appraisals therefore exclude Ruby 2.7 and support Ruby 3.0 through 4.0.

No library compatibility changes were required.

Validation

  • APPRAISAL_GROUP=knapsack_pro-9-rspec-3 bundle exec appraisal install — passed
  • APPRAISAL_GROUP=knapsack_pro-10-rspec-3 bundle exec appraisal install — passed
  • bundle exec rake test:knapsack_rspec test:knapsack_auto_instrument — knapsack_pro 7, 8, 9, and 10 appraisals passed on the host Ruby
  • ruby -c Appraisals — passed
  • bundle exec standardrb Appraisals Rakefile — passed
  • git diff --cached --check — passed before commit

This PR supersedes #550.

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The Ruby-version guard correctly omits knapsack_pro 9 on Ruby 2.7 while generating the appraisal on Ruby 3.0 and newer, and the six committed gemfile/lockfile pairs match that matrix. No diff-only behavioral regression was reproduced; full Bundler task execution was unavailable because the sandbox could not fetch the repository's existing dd-trace-rb Git dependency.

Was this helpful? React 👍 or 👎

📊 Validated against 8 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 6676701 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jul 24, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 97.30% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c5ae9af | Docs | Datadog PR Page | Give us feedback!

# Conflicts:
#	Appraisals
#	Rakefile

Copy link
Copy Markdown
Member Author

Consolidated update: this PR now covers both knapsack_pro 9 and 10 in one appraisal-family change. The helper spans 7..10, both knapsack_rspec and knapsack_auto_instrument TEST_METADATA axes and generated files are included, and Ruby < 3.0 remains excluded based on the dependency requirement. The combined targeted tasks for all four majors, Appraisals syntax check, scoped StandardRB, and diff checks pass. #550 is superseded by this PR.

@anmarchenko anmarchenko changed the title Add knapsack_pro 9 appraisal Add knapsack_pro 9 and 10 appraisals Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant