Add shoulda-matchers 8 appraisal#548
Closed
anmarchenko wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
More details
The new appraisal is gated to Ruby 3.3 and newer, matching shoulda-matchers 8's runtime requirement; executable matrix and lockfile checks found no user-facing regression. Full appraisal execution was unavailable because the sandbox lacks the appraisal executable and the repository's git-sourced dependency checkout.
📊 Validated against 10 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 344c978 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 344c978 | Docs | Datadog PR Page | Give us feedback! |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a shoulda-matchers 8 appraisal for the minitest/shoulda-context integration.
RubyGems reports shoulda-matchers 8.0.1 as the latest stable, non-yanked 8.x release. This independently adds
minitest-5-shoulda-context-2-shoulda-matchers-8and its generated Ruby 3.3, 3.4, and 4.0 gemfiles/lockfiles.Ruby support
shoulda-matchers 8 requires Ruby >= 3.3, so
AppraisalsandTEST_METADATAexclude Ruby 2.7–3.2. No compatibility changes were required.Validation
APPRAISAL_GROUP=minitest-5-shoulda-context-2-shoulda-matchers-8 bundle exec rake 'appraisal:install[3.3,3.4,4.0]'— passedspec:minitest_shoulda_contextappraisal runs on Ruby 3.3, 3.4, and 4.0 — 2 examples, 0 failures eachbundle exec rake test:minitest_shoulda_context— 6.x and 8.x appraisals passed on Ruby 3.4bundle exec standardrb— 501 files, no offensesbundle exec rake steep:check— no type errorsgit diff --cached --check— passed