Skip to content

Add shoulda-matchers 8 appraisal#548

Closed
anmarchenko wants to merge 1 commit into
mainfrom
agent/add-shoulda-matchers-8-appraisal
Closed

Add shoulda-matchers 8 appraisal#548
anmarchenko wants to merge 1 commit into
mainfrom
agent/add-shoulda-matchers-8-appraisal

Conversation

@anmarchenko

Copy link
Copy Markdown
Member

What does this PR do?

Adds a shoulda-matchers 8 appraisal for the minitest/shoulda-context integration.

RubyGems reports shoulda-matchers 8.0.1 as the latest stable, non-yanked 8.x release. This independently adds minitest-5-shoulda-context-2-shoulda-matchers-8 and its generated Ruby 3.3, 3.4, and 4.0 gemfiles/lockfiles.

Ruby support

shoulda-matchers 8 requires Ruby >= 3.3, so Appraisals and TEST_METADATA exclude Ruby 2.7–3.2. No compatibility changes were required.

Validation

  • APPRAISAL_GROUP=minitest-5-shoulda-context-2-shoulda-matchers-8 bundle exec rake 'appraisal:install[3.3,3.4,4.0]' — passed
  • Runtime-prefixed spec:minitest_shoulda_context appraisal runs on Ruby 3.3, 3.4, and 4.0 — 2 examples, 0 failures each
  • bundle exec rake test:minitest_shoulda_context — 6.x and 8.x appraisals passed on Ruby 3.4
  • bundle exec standardrb — 501 files, no offenses
  • bundle exec rake steep:check — no type errors
  • git diff --cached --check — passed

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The new appraisal is gated to Ruby 3.3 and newer, matching shoulda-matchers 8's runtime requirement; executable matrix and lockfile checks found no user-facing regression. Full appraisal execution was unavailable because the sandbox lacks the appraisal executable and the repository's git-sourced dependency checkout.

Was this helpful? React 👍 or 👎

📊 Validated against 10 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 344c978 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Jul 24, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 97.31% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 344c978 | Docs | Datadog PR Page | Give us feedback!

Copy link
Copy Markdown
Member Author

Superseded by #547, which now contains both shoulda-matchers 7 and 8 appraisal coverage. Please use #547 for review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant