Skip to content

[APPS][Superseded] Trace imported connection ID values#365

Closed
sdkennedy2 wants to merge 1 commit into
masterfrom
sdkennedy2/imported-connection-id-value-tracing-graph
Closed

[APPS][Superseded] Trace imported connection ID values#365
sdkennedy2 wants to merge 1 commit into
masterfrom
sdkennedy2/imported-connection-id-value-tracing-graph

Conversation

@sdkennedy2
Copy link
Copy Markdown
Collaborator

@sdkennedy2 sdkennedy2 commented May 13, 2026

Status

This draft PR is superseded and is being closed intentionally.

Why This Is Not The Direction

This branch proved that imported connection ID value tracing is possible, but it bundled too many concerns into one review:

  • enriching module graph records with import/export metadata
  • traversing import/export relationships to resolve static definitions
  • applying that resolver to action-catalog connectionId values
  • reshaping connection ID extraction internals and documentation at the same time

That made the PR too large to review clearly and kept too much generic module graph logic inside connection ID-specific code.

Replacement Plan

Plan 014 now splits this work into smaller PRs:

  1. build-plugins#371: enrich ParsedModuleRecord with domain-neutral module facts.
  2. Follow-up PR: add generic static definition resolution over those records.
  3. Follow-up PR: use that resolver to support imported connection ID values.

This PR is kept only as historical context for the prototype implementation. It should not be reviewed or merged.

QA Instructions

None. This draft is closed in favor of the split implementation above.

Blast Radius

No runtime or package impact. The PR is closed without merging.

@sdkennedy2 sdkennedy2 changed the title Trace imported backend connection ID values [APPS][Connections Part 9] Trace imported connection ID values May 13, 2026
@sdkennedy2
Copy link
Copy Markdown
Collaborator Author

@codex review
@cursor review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 98a8c40d8f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +77 to +79
return sources.map((source, index) => {
const resolvedId = staticDependencies[index] ?? resolvedBySource.get(source) ?? source;
resolvedBySource.set(source, resolvedId);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve dependency alignment when sources repeat

When a module imports/re-exports the same source more than once before another source, this index-based pairing shifts every later resolution because Rollup exposes importedIds/importedIdResolutions once per unique source. For example import './a'; import './a'; import { HTTP_ID } from './ids'; produces dependencies [a, ids], but this maps the second ./a to ids and leaves ./ids unresolved as the literal string, so imported connection IDs from ./ids fail as outside the collected graph. Reuse the cached resolution for a source before consuming the next dependency index, or build the mapping directly from Rollup's source order.

Useful? React with 👍 / 👎.

@sdkennedy2 sdkennedy2 marked this pull request as draft May 13, 2026 20:25
@sdkennedy2 sdkennedy2 changed the base branch from sdkennedy2/refactor-connection-id-extraction-modules to graphite-base/365 May 13, 2026 20:33
@sdkennedy2 sdkennedy2 force-pushed the graphite-base/365 branch from e08b6dc to ec10389 Compare May 15, 2026 14:59
@sdkennedy2 sdkennedy2 force-pushed the sdkennedy2/imported-connection-id-value-tracing-graph branch from 98a8c40 to eb5da50 Compare May 15, 2026 14:59
@sdkennedy2 sdkennedy2 changed the base branch from graphite-base/365 to master May 15, 2026 14:59
@sdkennedy2 sdkennedy2 force-pushed the sdkennedy2/imported-connection-id-value-tracing-graph branch from eb5da50 to 94bb8e9 Compare May 15, 2026 17:29
@sdkennedy2 sdkennedy2 changed the title [APPS][Connections Part 9] Trace imported connection ID values [APPS][Superseded] Trace imported connection ID values May 15, 2026
@sdkennedy2
Copy link
Copy Markdown
Collaborator Author

Closing this draft as superseded. The work is now split into smaller PRs starting with #371, followed by generic static definition resolution and then connection ID integration.

@sdkennedy2 sdkennedy2 closed this May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant